Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix remaining mypy errors and mistake in test suite #110

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

JorenB
Copy link
Contributor

@JorenB JorenB commented Sep 4, 2024

Note that non-test classes cannot be named Test... in a test suite since pytest will assume it's a test.

The types-Pillow package is stuck at 10.2 and is therefore inconsistent with the most recent Pillow version (10.4). As a result, some type ignore hints have to be added and may be removed in a future version.

All pre-commit checks and tests should now pass without warnings and/or errors.

@JorenB JorenB requested a review from EricMarcus-ai September 4, 2024 13:00
@moerlemans moerlemans self-requested a review September 4, 2024 15:20
Copy link
Contributor

@moerlemans moerlemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorenB JorenB merged commit f600d04 into main Sep 4, 2024
1 check passed
@JorenB JorenB deleted the fix/mypy-tests branch September 4, 2024 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants