Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make JSON output form compatible with RIPE Validator #16

Closed
job opened this issue Nov 4, 2018 · 2 comments · Fixed by #21
Closed

make JSON output form compatible with RIPE Validator #16

job opened this issue Nov 4, 2018 · 2 comments · Fixed by #21
Milestone

Comments

@job
Copy link
Contributor

job commented Nov 4, 2018

Arouteserver (and other software) relies on having the TAL name per entry in the JSON format, this is used for granular filtering on what ROAs to use and which not to use.

ARouteServer 2018-11-04 03:41:43,420 WARNING Invalid ROA: {u'prefix': u'91.231.153.0/24', u'asn': u'AS21485', u'maxLength': 24}, missing trust anchor

If the intention is that Routinator can be used as a drop-in replacement for RIPE NCC's validator, please make the JSON format compatible:

{
  "roas" : [ {
    "asn" : "AS0",
    "prefix" : "202.13.72.0/24",
    "maxLength" : 24,
    "ta" : "APNIC RPKI Root"
  }, {
    "asn" : "AS0",
    "prefix" : "203.147.108.0/31",
    "maxLength" : 31,
    "ta" : "APNIC RPKI Root"
  }, 
   ....
@partim
Copy link
Member

partim commented Nov 4, 2018

Thanks for the report!

A quick fix could be to add a field with a value of "N/A" or somesuch to the JSON. Would that be helpful in the short run?

For the next version, we’ll add proper support. However, as we are using RFC 7760 TAL format, there is no name available. We could use the file name, the file name without the extension .tal or even the Subject Name of the root certificate, although the latter is confusingly different between RIRs so maybe that is not the best choice.

@job
Copy link
Contributor Author

job commented Nov 4, 2018 via email

@partim partim added this to the 0.2.0 milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants