Accept both PRIVATE KEY and RSA PRIVATE KEY items in PEM files. #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRiKE
approved these changes
Dec 13, 2022
partim
added a commit
that referenced
this pull request
Dec 13, 2022
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 14, 2023
Pkgsrc changes: * Update cargo-depends.mk, update checksums. Upstream changes: ## 0.12.2 "Brutti, sporchi e cattivi" Release 2023-09-13. Bug Fixes * Fixed various decoding issues that could lead to a panic when processing invalid RPKI objects. ([#891], via bcder release 0.7.3. Found by Haya Shulman, Donika Mirdita and Niklas Vogel. Assigned CVE-2023-39915) * Check the request URI when generating a path for storing a copy of a RRDP response with the `rrdp-keep-responses` option to avoid path traversal. ([#892]. Found by Haya Shulman, Donika Mirdita and Niklas Vogel. Assigned CVE-2023-39916.) [#891]: NLnetLabs/routinator#891 [#892]: NLnetLabs/routinator#892 ## 0.12.1 "Plan uw reis in de app" Released 2023-01-04. There are no changes since 0.12.1-rc2. ## 0.12.1-rc2 Released 2022-12-13. Bug Fixes * Allow private keys prefixed both with `BEGIN PRIVATE KEY` and `BEGIN RSA PRIVATE KEY` in the files referred to by `http-tls-key` and `rtr-tls-key` configuration options. ([#831], [#832]) [#831]: NLnetLabs/routinator#831 [#832]: NLnetLabs/routinator#831 ## 0.12.1-rc1 Released 2022-12-05. Bug Fixes * Actually use the `extra-tals-dir` config file option. ([#821]) * On Unix, if chroot is requested but no working directory is explicitly provided, set the working directory to the chroot directory. ([#823]) * Fixed the error messages printed when the `http-tls-key` or `http-tls-cert` options are required but missing. They now refer to HTTP and not, as previously, to RTR. ([#824] by [@SanderDelden]) Other Changes * Switch the packaging workflow to use [Ploutos]. ([#816]) [#816]: NLnetLabs/routinator#816 [#821]: NLnetLabs/routinator#821 [#823]: NLnetLabs/routinator#823 [#824]: NLnetLabs/routinator#824 [@SanderDelden]: https://github.com/SanderDelden [Ploutos]: https://github.com/NLnetLabs/ploutos/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the code that reads the private key file for both HTTP and RTR to accept both the PRIVATE KEY items from PKCS#8 and RSA PRIVATE KEY items from PKCS#1.
Fixes #825.