Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn-log the config file used with certain commands. #959

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

partim
Copy link
Member

@partim partim commented May 17, 2024

This PR adds printing of the config file used to some of the commands.

Fixes #949.

@partim partim requested a review from a team May 17, 2024 13:15
@partim partim merged commit a19e809 into main May 29, 2024
10 checks passed
@partim partim deleted the print-config-path branch May 29, 2024 09:09
partim added a commit that referenced this pull request Jun 10, 2024
Breaking changes

* Keep the content of an RRDP repository in a single file rather than
  as individual files under a directory. ([#886])
* Changed the `summary` output format to have all lines end in a
  semicolon. ([#907])
* Changed the options used for `rsync`. The options `-rtO --delete` are
  now always used. The options set in the `rsync-args` are added or, if
  that is not used, `-z` and `--no-motd`, as well as `--contimeout=10`
  if it is supported by the rsync command, and `--max-size` if the
  `max-object-size` option has not been set to 0. ([#962])

New

* The `chain_validity` value in the `jsonext` format now considers the
  validity of the manifest’s EE certificates. A new `stale` value shows
  the time when any of the publication points along the way will become
  stale. ([#945])
* If a collected manifest has a lower manifest number or an older
  thisUpdate field than a stored manifest for the same CA, the collected
  manifest is ignored and the stored publication point is used instead.
  This implements a requirement added in [RFC 9286]. ([#946], [#954])
* The number of delta entries in a RRDP notification file is now limited
  to 500 by default. If there are more entries, the deltas are ignored and
  the snapshot is used. The limit can be changed through the new
  `rrdp-max-delta-list-len` configuration value. ([#961])
* The RRDP collector now falls back to a snapshot update if the hash of
  a delta listed in the notification file has changed from the previous
  update. This implements [draft-ietf-sidrops-rrdp-desynchronization-00].
  ([#951])
* The RRDP collector now enforces that all URIs referred to or redirected
  to by an RRDP server have the same origin as the rpkiNotify URI in the
  CA certificate. ([#953])
* The config file used is now printed for some commands. This should help
  with avoiding confusion when running Routinator as different users.
  ([#959])

Bug fixes

* Fixed an issue where the refresh time was calculated as zero under
  certain conditions until the dataset was updated. ([#940])
* Add the current RRDP serial number to the RRDP server metrics when a
  Not Modified response is received so that Prometheus shows a constant
  value.
partim added a commit that referenced this pull request Jun 20, 2024
…970)

Breaking changes

* Keep the content of an RRDP repository in a single file rather than
  as individual files under a directory. ([#886])
* Switched to the all-new version 0.4 of the Routinator UI. This also
  changes the way we import the UI into Routinator by simply including the
  built assets which means downloads are not necessary during the build
  process any more. ([#952])
* Changed the `summary` output format to have all lines end in a
  semicolon. ([#907])
* Changed the options used for `rsync`. The options `-rtO --delete` are
  now always used. The options set in the `rsync-args` are added or, if
  that is not used, `-z` and `--no-motd`, as well as `--contimeout=10`
  if it is supported by the rsync command, and `--max-size` if the
  `max-object-size` option has not been set to 0. ([#962])

New

* The `chain_validity` value in the `jsonext` format now considers the
  validity of the manifest’s EE certificates. A new `stale` value shows
  the time when any of the publication points along the way will become
  stale. ([#945])
* If a collected manifest has a lower manifest number or an older
  thisUpdate field than a stored manifest for the same CA, the collected
  manifest is ignored and the stored publication point is used instead.
  This implements a requirement added in [RFC 9286]. ([#946], [#954])
* The number of delta entries in a RRDP notification file is now limited
  to 500 by default. If there are more entries, the deltas are ignored and
  the snapshot is used. The limit can be changed through the new
  `rrdp-max-delta-list-len` configuration value. ([#961])
* The RRDP collector now falls back to a snapshot update if the hash of
  a delta listed in the notification file has changed from the previous
  update. This implements [draft-ietf-sidrops-rrdp-desynchronization-00].
  ([#951])
* The RRDP collector now enforces that all URIs referred to or redirected
  to by an RRDP server have the same origin as the rpkiNotify URI in the
  CA certificate. ([#953])
* The config file used is now printed for some commands. This should help
  with avoiding confusion when running Routinator as different users.
  ([#959])

Bug fixes

* Fixed an issue where the refresh time was calculated as zero under
  certain conditions until the dataset was updated. ([#940])
* Add the current RRDP serial number to the RRDP server metrics when a
  Not Modified response is received so that Prometheus shows a constant
  value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print the config file used upon startup
2 participants