Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Adding Source Maps Section #54

Closed
wants to merge 1 commit into from
Closed

Update README.md - Adding Source Maps Section #54

wants to merge 1 commit into from

Conversation

hbobenicio
Copy link

Just adding a Source Maps section to the README.md docs.

This is the result on the issue #53.

After some painful debugging section, I just realized that optimize-css-assets-webpack-plugin would pass cssProcessorOptions to cssnano, and the defaults used by this plugin would result in no source-maps.

This doc section can save some time for others that are using the default configuration and want to use source-maps, but don't know how it is truncated.

Anyway... it's open to discussion and improvements. Here it is.

@hbobenicio
Copy link
Author

@NMFR there it is

@hbobenicio
Copy link
Author

I'm closing this PR because maybe this is not actually the correct way to configure it.
It works for me, but it may confuse more people about the actual recommended way to achieve this (source maps + bundle otimization).
We're still discussing it at issue #53 .

@hbobenicio hbobenicio closed this Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant