-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring EMC fms_mixedmode up to date with GFDL main #15
Bring EMC fms_mixedmode up to date with GFDL main #15
Conversation
Co-authored-by: Eric Stofferahn <Eric.Stofferahn@noaa.gov>
Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
Update build actions Change images to organization's repo and fix mixed mode parser test failure
Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
…r of constants4.F90
* Change send_data interface and any necessary routines for mixed real precision support * Adds an r4 size constants file BREAKING CHANGE: changes some argument types in diag_manager, tracer_manager, sat_vapor_pres, and time_manager from real to class(*) Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com>
…tarts (NOAA-GFDL#889) * update to fms2_io to allow reads to ignore embedded checksums on a fileobj basis * added fms2_io test cases for the ignore_checksum option to restart reads tests the domain, domain_wrap, and bc restart options
…h only as expected (NOAA-GFDL#904)
…" (NOAA-GFDL#914) This reverts commit 516a5ef.
…-GFDL#859) Remove unused variables throughout and changes/removals for other warnings such as uninitialized values and implicit casts
* Changes master to main in CONTRIBUTING.md * Claifies function return documentation in CODE_STYLE.md
…L#907) * Adds support for logical variables in the yaml parser * correctly determines if a string is true or false
…A-GFDL#920) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
Rewrites test script to use added testing shell functions Adds previously skipped or removed unit tests and support for testing with input files Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: Uriel Ramirez <uriel.ramirez@noaa.gov>
…erride (NOAA-GFDL#933) Enables the processing of an empty or non-existent data_table or data_table.yaml from within data_override, so that any routine can call data_override_init without worry
Adds module and accompanying test for common string operations
…ture elimination. (NOAA-GFDL#952)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of changes, are there any conflicts with the mixed-mode code updates?
There were two files with conflicts: |
One of the Github Actions tests failed with this message:
Will fix this. |
All GitHub Actions tests passed (except the one using parallelWorks) with the latest commit. |
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheck
passes