Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more F90 updates #587

Merged
merged 5 commits into from
Apr 18, 2024
Merged

more F90 updates #587

merged 5 commits into from
Apr 18, 2024

Conversation

jbathegit
Copy link
Collaborator

Part of #254
Part of #328

@jbathegit
Copy link
Collaborator Author

So I was about to submit this bundle for review, but we suddenly have an issue with the "Spack / Spack (ubuntu-latest, +python ~shared) (pull_request)" CI test.

I've tried re-running it twice but to no avail. I'm not sure why it's failing all of a sudden, but one thing I did note is that it's trying to download the bufr test files from the emcrzdm server, which isn't available right now b/c of the ongoing recovery from all of the problems NCO had yesterday in their data center. And Spack.yml is apparently the only YAML file which doesn't include the TEST_FILE_DIR option to cmake (along with a key attribute under a "cache-data" option) to instead copy the bufr test files from /home/runner/data rather than trying to download them from emcrzdm every time. So that's one thing that should probably be addressed in Spack.yml.

However, that alone wouldn't explain why the corresponding "Spack / Spack (ubuntu-latest, ~python +shared) (pull_request)" CI test, which is also run out of the same Spack.yml workflow, is still working fine even though emcrzdm isn't currently available. So something else must be going on here.

@AlexanderRichert-NOAA @edwardhartnett any thoughts?

@AlexanderRichert-NOAA
Copy link
Contributor

The Python unit tests are failing with Failed to change working directory to /tmp/runner/spack-stage/spack-stage-bufr-develop-zeuqln3tiwikb7hge2x4q6z6ur2w7g3u/spack-build-zeuqln3/test/testfiles : No such file or directory which might suggest it's related to the test files. I'll make a test PR where I'll see if I can use the existing cached test files and see if that does the trick. And I agree the Spack workflow should include the cache usage.

@jbathegit jbathegit marked this pull request as ready for review April 17, 2024 14:15
@jbathegit
Copy link
Collaborator Author

Thanks again Alex for your work in #588 to fix the above Spack CI issue!

@jbathegit jbathegit merged commit a8108e5 into develop Apr 18, 2024
9 checks passed
@jbathegit jbathegit deleted the jba_stillmoreF90 branch April 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants