Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more updates #599

Merged
merged 7 commits into from
Jun 6, 2024
Merged

more updates #599

merged 7 commits into from
Jun 6, 2024

Conversation

jbathegit
Copy link
Collaborator

Part of #254
Part of #328
Part of #445

@jbathegit
Copy link
Collaborator Author

OK all good now. There was a bug in rewnbf that was always restoring the subset pointer to point to the first subset (i.e. the beginning) of a restored BUFR message whenever the subroutine was called with isr=1, even if the subset pointer had been pointing to a different subset in the message when the routine was called previously with isr=0. I had fixed this bug in an earlier commit, but there was an existing Python test which had been overcoming this bug by re-reading up to the expected subset in the message. So once I fixed the bug in the library, that Python test began failing until I now just removed the extra script lines which had previously been re-positioning the subset pointer to overcome the bug.

@jbathegit jbathegit merged commit 2cdc540 into develop Jun 6, 2024
9 checks passed
@jbathegit jbathegit deleted the jba_stillnotdone branch June 6, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants