Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All NCEPLIBS must have unit tests, and use continuous integration with GitHub actions #130

Closed
edwardhartnett opened this issue Sep 29, 2020 · 9 comments
Assignees
Labels
test Testing

Comments

@edwardhartnett
Copy link
Contributor

All NCEPLIBS repos must have testing. All must use CI with GitHub actions for testing.

A reasonably complex example, which builds and uses HDF5 and netCDF, can be found here:
https://github.com/NCAR/ParallelIO/blob/master/.github/workflows/a4.yml

@BenjaminTJohnson
Copy link

For CRTM, specifically, we're working on getting this done over the next month.

We have multiple build support requirements due to CRTM being integrated in multiple model platforms.

@edwardhartnett
Copy link
Contributor Author

Almost all projects in NCEPLIBS already have CI with GitHub actions, which is great. But most of them are running no tests, which is the next area we need to improve.

@GeorgeGayno-NOAA
Copy link

IP and IP2 have tests. But I don't know if they are working. I think @kgerheiser is working on this.

@kgerheiser
Copy link
Contributor

kgerheiser commented Oct 15, 2020

I'm currently in the process of porting ip and ip2's tests to CMake

@BenjaminTJohnson
Copy link

I'll be providing a cmake build for CRTM within the "next couple of weeks". We have a code release coming up soon, once that's done, I'll work with the team to get linked to our releases and work out any build/test issues.

@edwardhartnett
Copy link
Contributor Author

To measure code coverage, compile like this:

cmake -DCMAKE_Fortran_FLAGS="-fprofile-arcs -ftest-coverage" -DENABLE_TESTS=ON .. && make clean && make VERBOSE=1 && make test
gcovr -r ../ . --html --html-details -o example-html-details.html

@jbathegit
Copy link

Even though we didn't get to them during today's shortened NCEPLIBS meeting, here are my testing notes and tips: https://docs.google.com/document/d/1-vD24bjNcJTXGeu4rAHhJ9u_S7WcUmd75vX2wrFik88/edit?usp=sharing

@edwardhartnett
Copy link
Contributor Author

We will go over these at the next NCEPLIBS meeting. I look forward to it!

@edwardhartnett
Copy link
Contributor Author

We now have at least some unit tests, and good CI, on all active NCEPLIBS projects. I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing
Projects
None yet
Development

No branches or pull requests

5 participants