-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Basemap dependency #61
Conversation
@ricampos please let us know if this will cause any issues or if something needs to be added in its place. Based on this PR it looks like these functions aren't really used, but I could definitely be reading the code incorrectly. We do not want to break anything, but would like to remove basemap. |
Hi. It is ok, it is a good udpate. The pvalstats.py will take the pallete from matplotlib.pyplot. |
It looks like the update to ww3tools/organizeDistanceToCoast.py is equally as simple, so updating that in this PR is a great idea. The shiftgrid function is a more complicated update, so I recommend us creating an issue so that we can track the need to do this, but holding off on that for another PR. Does that sound okay @ricampos ? |
Yes. I agree. Thank you |
Issue #64 has been created to track the shiftgrid. @Ghazal-Mohammadpour let me know if you have any questions about also removing basemap from ww3tools/organizeDistanceToCoast.py in this PR. |
@ricampos - @Ghazal-Mohammadpour has made the changes and we made the new issue for shiftgrid. |
Perfect. I can see the modifications. Thank you |
Description
This PR removes the Basemap dependency from the code. Basemap is being deprecated because Cartopy provides similar functionality for plotting geographic data.
Changes:
Explanation