Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to read increment files on native cubed sphere grid #837

Merged
merged 25 commits into from
Aug 27, 2024

Conversation

DavidNew-NOAA
Copy link
Contributor

Description

This PR is a companion to GFDL Atmospheric Cubed Sphere PR #342 which adds the ability to read increment files on native cubed sphere grid. Most of the technical details and motivation are in the description of that PR. This PR simply created the namelist option "increment_file_on_native_grid" to turn this feature on.

Issue(s) addressed

N/A

Testing

See description of GFDL Atmospheric Cubed Sphere PR #342 for a summary of testing.

Dependencies

  • waiting on GFDL Atmospheric Cubed Sphere PR #342

@DusanJovic-NOAA
Copy link
Collaborator

According to description this PR depends on GFDL Atmospheric Cubed Sphere PR #342. Please update .gitmodules to point to your atmos_cubed_sphere fork and update the atmos_cubed_sphere submodule.

@DavidNew-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA Done

@DusanJovic-NOAA
Copy link
Collaborator

You also need to update .gitmodules to point to your atmos_cubed_sphere fork. The current atmos_cubed_sphere hash (953d582) doesn't exist in NOAA-GFDL/GFDL_atmos_cubed_sphere and recursive clone fails. I think that's the reason why the CI tests fail. https://github.com/NOAA-EMC/fv3atm/actions/runs/9303222835/job/25605091052?pr=837

Also I do not see the corresponding ufs-weather-model PR that points to this PR which is needed in order to run full ufs-wm regression tests.

@DavidNew-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA There was actually a compilation error in my atmos_cubed_sphere PR that did not show up with Intel but did with GCC. Now that I fixed it, the CI test passes without having to update .gitmodules. Should I still update it? I ask because won't that change have to be reverted back to point to the NOAA-EMC repo eventually?

Also, I just created a UFSWM PR that points to the FV3 hash for this PR: ufs-community/ufs-weather-model#2304

@DavidNew-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA Is there anything I need to do to speed this PR along now that NOAA-GFDL/GFDL_atmos_cubed_sphere#342 is approved?

@DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA Is there anything I need to do to speed this PR along now that NOAA-GFDL/GFDL_atmos_cubed_sphere#342 is approved?

@jkbk2004 Please schedule this PR for merge.

@zach1221
Copy link
Collaborator

zach1221 commented Aug 27, 2024

@DavidNew-NOAA cubed-sphere PR-342 is merged. Please update the .gitmodule url, and hash.
Hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@ac3055e

@zach1221 zach1221 requested a review from jkbk2004 August 27, 2024 13:29
@zach1221
Copy link
Collaborator

@jkbk2004 please merge this PR.

@jkbk2004 jkbk2004 merged commit 70b3065 into NOAA-EMC:develop Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants