-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to read increment files on native cubed sphere grid #837
Add ability to read increment files on native cubed sphere grid #837
Conversation
According to description this PR depends on GFDL Atmospheric Cubed Sphere PR #342. Please update |
@DusanJovic-NOAA Done |
You also need to update Also I do not see the corresponding ufs-weather-model PR that points to this PR which is needed in order to run full ufs-wm regression tests. |
@DusanJovic-NOAA There was actually a compilation error in my atmos_cubed_sphere PR that did not show up with Intel but did with GCC. Now that I fixed it, the CI test passes without having to update .gitmodules. Should I still update it? I ask because won't that change have to be reverted back to point to the NOAA-EMC repo eventually? Also, I just created a UFSWM PR that points to the FV3 hash for this PR: ufs-community/ufs-weather-model#2304 |
@DusanJovic-NOAA Is there anything I need to do to speed this PR along now that NOAA-GFDL/GFDL_atmos_cubed_sphere#342 is approved? |
@jkbk2004 Please schedule this PR for merge. |
@DavidNew-NOAA cubed-sphere PR-342 is merged. Please update the .gitmodule url, and hash. |
@jkbk2004 please merge this PR. |
Description
This PR is a companion to GFDL Atmospheric Cubed Sphere PR #342 which adds the ability to read increment files on native cubed sphere grid. Most of the technical details and motivation are in the description of that PR. This PR simply created the namelist option "increment_file_on_native_grid" to turn this feature on.
Issue(s) addressed
N/A
Testing
See description of GFDL Atmospheric Cubed Sphere PR #342 for a summary of testing.
Dependencies