-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on PHA_MLD_CALC and associated runtime parameters to allow MOM6 to calculate a photoacclimation MLD #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes for the PHA_MLD_CALC and the MLD diagnostic look correct.
I would recommend updating the name of the diag_table file because it has different entries than the 2023-03 version. If there is a reason not to rename it to a more recent date I would suggest we remove "2023-03" from the name at least.
Note that with these changes MLD_DBM is what should be compared to the de Boyer Montegut dataset. The MLD_003 diagnostic should be consistent with previous results as long as no answer-changing flags are turned on.
As titled. this PR updates the model configurations to enable MOM6 to calculate the photoacclimation mixed layer depth (MLD). We have also updated the
diag_table
to illustrate how to output both the defaultMLD003
and a user-specified MLD.While we have passed
photo_acc_dpth
togeneric_tracer_source
, currently we do not passphoto_acc_dpth
further intogeneric_COBALT_update_from_source
for the final photoacclimation calculation:https://github.com/NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC/blob/dc276573f5cca0a63312ba97d0c1b7f6c5c81ac0/generic_tracers/generic_tracer.F90#L554-L558
so the answers remain the same in this PR. @theresa-morrison has another PR now which will eventually bring in MOM6-calculated photoacclimation MLD into COBALT and we except the answer changes for that PR.