Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern_diag_manager:: flush_nc_files is not implemented in the new diag manager #1501

Closed
uramirez8707 opened this issue Apr 29, 2024 · 1 comment · Fixed by #1506
Closed
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@uramirez8707
Copy link
Contributor

Is your feature request related to a problem? Please describe.
flush_nc_files=.true. has not been implemented in the new diag manager and it would not work:

LOGICAL :: flush_nc_files = .FALSE. !< Control if diag_manager will force a
!! flush of the netCDF file on each write.
!! Note: changing this to .TRUE. can greatly
!! reduce the performance of the model, as the
!! model must wait until the flush to disk has
!! completed.

Describe the solution you'd like
flush_nc_files=.true. should work as it did with the old diag manager.

Describe alternatives you've considered
N/A

Additional context
N/A

@uramirez8707 uramirez8707 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Apr 29, 2024
@uramirez8707
Copy link
Contributor Author

Fixed in #1506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant