Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement flush_nc_files in the new diag manager and adds a test #1506

Merged
merged 2 commits into from
May 17, 2024
Merged

implement flush_nc_files in the new diag manager and adds a test #1506

merged 2 commits into from
May 17, 2024

Conversation

uramirez8707
Copy link
Contributor

Description
implement flush_nc_files in the new diag manager and adds a test

Fixes #1501

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 changed the base branch from dmUpdate to main May 7, 2024 13:48
rem1776
rem1776 previously approved these changes May 8, 2024
View reviewed changes
@uramirez8707 uramirez8707 mentioned this pull request May 13, 2024
Closed
@rem1776 rem1776 merged commit 98e2ebd into NOAA-GFDL:main May 17, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

@bensonr bensonr Awaiting requested review from bensonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modern_diag_manager:: flush_nc_files is not implemented in the new diag manager
2 participants
@uramirez8707 @rem1776