Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diag_manager writing a default fill value when there is no data #391

Closed
thomas-robinson opened this issue Apr 17, 2020 · 3 comments
Closed
Assignees
Labels
bug Issue/PR that reports or fixes a given discovered bug enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. feature request question
Milestone

Comments

@thomas-robinson
Copy link
Member

Is your feature request related to a problem? Please describe.
The diag_manager outputs a NETCDF default fill value if a buffer is to be written without being initialized. The buffer is initialized with this value. This happens when running a GFDL model for 0 days.

Describe the solution you'd like
Up for debate is what should happen in the case. Should there be no file? If the missing_value attribute is added, should the array be filled with the missing_value specified in the code? If _fillvalue is defined, should it use that value?

Describe alternatives you've considered

Additional context

@thomas-robinson thomas-robinson added enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. question feature request bug Issue/PR that reports or fixes a given discovered bug labels Apr 17, 2020
@thomas-robinson thomas-robinson added this to the 2020.03 milestone Apr 17, 2020
@thomas-robinson
Copy link
Member Author

@uramirez8707 We were just talking about this. Let's put it on the agenda for the next FMS meeting

@thomas-robinson
Copy link
Member Author

In the new diag manager, we will open the file when it's time to write (has data to write) and write the meta data at the first open. This is a change in behavior that needs to be documented clearly.

@uramirez8707
Copy link
Contributor

Fixed in #1505
See documentation for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that reports or fixes a given discovered bug enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. feature request question
Projects
None yet
Development

No branches or pull requests

3 participants