-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dmUpdate branch into main #1505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the 'modern' register routines in diag_manager
…or out without flag (NOAA-GFDL#944)
* remove the realm key * Changed output_name to an optional field
thomas-robinson
previously approved these changes
May 3, 2024
Thank you to everyone who contributed to this project especially @uramirez8707 @rem1776 @ngs333 @ganganoaa . Your contributions over the YEARS have been invaluable to the improvement of the diag manager code. Now let's merge this beast in and deal with the bugs lol. |
rem1776
force-pushed
the
dmupdate-rebase-pt101
branch
from
May 3, 2024 13:41
ad1708c
to
a00c332
Compare
rem1776
force-pushed
the
dmupdate-rebase-pt101
branch
from
May 3, 2024 14:03
7ee42c7
to
65b16d5
Compare
thomas-robinson
previously approved these changes
May 3, 2024
thomas-robinson
approved these changes
May 3, 2024
This was referenced May 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings over the changes from dmUpdate into the main branch. I rebased the branch to get rid of duplicate commits and also to clean up the formatting of the commit messages, this way we can merge this instead of squashing it into one commit.
After the rebase I ran a diff so these changes should be exactly whats in dmUpdate, content-wise (minus the uml diagrams).
How Has This Been Tested?
make distcheck on amd box
Checklist:
make distcheck
passes