Add time info to diag file obj #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| character (len=:), private, allocatable :: file_unlimdim !< The name of the unlimited dimension | ||
| type(subRegion_type), private :: file_sub_region !< type containing info about the subregion, if any | ||
| integer, private :: file_new_file_freq !< Frequency for closing the existing file | ||
| character (len=:), private, allocatable :: file_new_file_freq_units !< Time units for creating a new file. | ||
| integer, private :: file_new_file_freq_units !< Time units for creating a new file. |
There was a problem hiding this comment.
I think I missed this: where does the units get converted to an integer?
There was a problem hiding this comment.
The units are read to a string buffer and the converter to a integer.
FMS/diag_manager/fms_diag_yaml.F90
Lines 475 to 478 in 8c54912
FMS/diag_manager/fms_diag_yaml.F90
Lines 678 to 679 in 8c54912
thomas-robinson
approved these changes
Aug 8, 2022
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* adds the time info to the fileobj, modifies the yaml obj to store the time_units as integers instead of strings * fix a line length issue and fix test, init the new optional integers * initialize next_open * return if the start_time is already the base_time * refactors the code that sets and converts the time_units to integers * refactors set_valid_time_units
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* adds the time info to the fileobj, modifies the yaml obj to store the time_units as integers instead of strings * fix a line length issue and fix test, init the new optional integers * initialize next_open * return if the start_time is already the base_time * refactors the code that sets and converts the time_units to integers * refactors set_valid_time_units
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the timing information to the diag file obj
Modifies the yaml to save the frequencies as an integer instead of strings to make it more efficient
Modifies tests for this change
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses