Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ifdef cleanup #1049

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Ifdef cleanup #1049

merged 4 commits into from
Oct 7, 2022

Conversation

thomas-robinson
Copy link
Member

Description
Moves the #ifdef use_yaml errors to the fms_diag_object routines. The rest of the modern diag modules are completely ifdef'd out.

Fixes #

How Has This Been Tested?
github ci

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson thomas-robinson merged commit 25ffcea into NOAA-GFDL:dmUpdate Oct 7, 2022
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@thomas-robinson
Ifdef cleanup (NOAA-GFDL#1049)
618a145 
* Cleans up ifdefs for use_yaml.  Now errors in the fms_diag_object

* Removes reliance on fms_diag_yaml_mod in diag_manager
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@thomas-robinson
Ifdef cleanup (NOAA-GFDL#1049)
ee02608 
* Cleans up ifdefs for use_yaml.  Now errors in the fms_diag_object

* Removes reliance on fms_diag_yaml_mod in diag_manager
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@thomas-robinson
chore: modern diag ifdef cleanup (NOAA-GFDL#1049)
95aa96f
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@thomas-robinson
chore: modern diag ifdef cleanup (NOAA-GFDL#1049)
3760f87
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@thomas-robinson
chore: modern diag ifdef cleanup (NOAA-GFDL#1049)
9a26ea8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uramirez8707 uramirez8707 uramirez8707 approved these changes

@rem1776 rem1776 rem1776 approved these changes

@ngs333 ngs333 Awaiting requested review from ngs333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomas-robinson @rem1776 @uramirez8707