mixed precision column_diagnostics #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
requested review from
rem1776,
thomas-robinson and
bensonr
as code owners
bensonr
approved these changes
Nov 29, 2022
mlee03
changed the title
|
@thomas-robinson @bensonr, ready for review |
rem1776
approved these changes
Dec 13, 2022
mcallic2
approved these changes
Dec 21, 2022
| !private | ||
|
|
||
| !-------------------------------------------------------------------- | ||
| !---- namelist ----- | ||
|
|
||
| real :: crit_xdistance = 4.0 !< model grid points must be within crit_xdistance in | ||
| real(kind=r8_kind) :: crit_xdistance = 4.0 !< model grid points must be within crit_xdistance in |
There was a problem hiding this comment.
I think we should avoid using the d for exponents since its not as portable. Some compilers count the doubles as double whatever the default is so this would end up being 16 bytes with gcc for a normal compilation.
mcallic2
approved these changes
Jan 19, 2023
added 3 commits
March 15, 2023 11:46
mcallic2
approved these changes
May 15, 2023
mcallic2
approved these changes
Aug 31, 2023
added 3 commits
September 1, 2023 13:08
rem1776
added a commit
that referenced
this pull request
Oct 6, 2023
* mixed precision column_diagnostics (#1076) * mixed precision mosaic2 (#1074) * mixed precision topography unit tests (#1364) * mixed precision tridiagonal (#1363) * mixed precision: add test for coupler_types and data_override changes (#1361) * Mixed precision `amip_interp_mod` (#1365) BREAKING CHANGE: Several variables and arrays which were previously public have been made private. These variables and arrays are not used in ice_amip or ocean_amip. amip_interp_type(r4_kind) and amip_interp_type(r8_kind) should be used for r4_kind and r8_kind precision, respectively. amip_interp_type without a kind parameter defaults to r8_kind. Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov> Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this Pull Request,
column_diagnosticshas been edited to as part of the mixed-mode project in FMSHow Has This Been Tested?
make and make check passes with Intel and GCC
Checklist:
make distcheckpasses