Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compiler support to readme and fix some compiler bugs #1103

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jan 5, 2023

Description
Adds a little compiler support section to the readme with a chart for whether fms builds and tests without error on different compilers. Let me know if you think it needs any more info

Also puts in two small fixes for compiler bugs:

  • one line fix for failures coming from the mpp_checksum test with more recent gnu versions
  • fixes a compilation error with intel's llvm based c compiler (var declarations in for loops typically aren't allowed in c, not sure why the other compilers allowed it)

How Has This Been Tested?
amd box + on gaea

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 7b6e867 into NOAA-GFDL:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants