Fix send_data race condition(?) + add send_data tests #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1647,6 +1647,7 @@ LOGICAL FUNCTION send_data_3d(diag_field_id, field, time, is_in, js_in, ks_in, & | |||
| IF ( fms_error_handler('diag_manager_mod::send_data_3d', err_msg_local, err_msg) ) RETURN | |||
| END IF | |||
| if (use_modern_diag) then !> Set up array lengths for remapping | |||
| field_modern => null() | |||
There was a problem hiding this comment.
You should use nullify here I think...
There was a problem hiding this comment.
i think they do the same thing
| if (id_y3 .ne. 4) call mpp_error(FATAL, "The y3 axis does not have the expected id") | ||
| if (id_ug .ne. 5) call mpp_error(FATAL, "The ug axis does not have the expected id") | ||
| if (id_z .ne. 6) call mpp_error(FATAL, "The z axis does not have the expected id") | ||
| if (.not. debug) then |
There was a problem hiding this comment.
What is debug supposed to do? Why are these checks in here if they are just being skipped? Are the test specific?
There was a problem hiding this comment.
debug is a namelist flag. when .true. it ignored the ids checks.
FMS/test_fms/diag_manager/test_modern_diag.F90
Lines 81 to 84 in 488dfa1
This is going to be useful when debugging because I will be able to modify the diag_table.yaml to just include whatever feature I am debugging (like static fields, or diurnal fields, etc)
| used = send_data(id_var6, var_data%var6, Time) | ||
| used = send_data(id_var7, var_data%var6, Time) | ||
|
|
||
| !TODO I don't know about this (scalar field) or how this is suppose to work #WUT |
thomas-robinson
approved these changes
Feb 8, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses