Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing tags to nested do loops in math functions #1139

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

ngs333
Copy link
Contributor

@ngs333 ngs333 commented Feb 27, 2023

This PR adds missing tags to nested do loops in math functions in file fms_diag_fieldbuff_update.fh. The tags were present in the baseline for some time before the buffer update (math) function PR was created,
but somehow they were omitted.

Fixes # (issue)

How Has This Been Tested?
Standard unit tests pass. Some tests that reproduced the problem were
ran and they also pass.

Checklist:

  • [X ] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my own code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings
  • [X ] Any dependent changes have been merged and published in downstream modules
  • [ X] New check tests, if applicable, are included
  • [X ] make distcheck passes

@ngs333 ngs333 marked this pull request as ready for review February 27, 2023 16:01
Copy link
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick run with SPEAR and the history files are now reproducing. @rem1776 @thomas-robinson i think this should be merged so we could do more, longer tests.

@thomas-robinson
Copy link
Member

@rem1776 merge and tag with 2023.01-beta2

@rem1776 rem1776 merged commit 74d8e73 into NOAA-GFDL:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants