Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time_interp_external2: Check field's existence before calling variable_att_exists in init_external_field #1193

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

J-Lentz
Copy link
Contributor

@J-Lentz J-Lentz commented Apr 14, 2023

variable_att_exists crashes when it is called on a nonexistent variable. Therefore, in init_external_field, the existence of the field should be checked before it is passed to variable_att_exists. This fix is required for the land model I/O API update.

Fixes #1192

How Has This Been Tested?
Compiles on the AMD box with Intel compiler.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

`variable_att_exists` crashes when it is called on a nonexistent variable.
Therefore, in `init_external_field`, the existence of the field should be
checked before it is passed to `variable_att_exists`.
@rem1776 rem1776 merged commit cbceb9f into NOAA-GFDL:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init_external_field in time_interp_external2_mod crashes when called for nonexistent field
2 participants