mixed-precision diag_integral_mod #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
commented
Jul 19, 2023
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/diag_manager/include> | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/field_manager/include> |
There was a problem hiding this comment.
Note to reviewers: field_manager was included twice. Hence this line was deleted in this PR
mcallic2
approved these changes
Jul 26, 2023
mcallic2
approved these changes
Jul 31, 2023
mcallic2
reviewed
Jul 31, 2023
mcallic2
reviewed
Jul 31, 2023
mcallic2
approved these changes
Jul 31, 2023
added 2 commits
August 2, 2023 11:16
J-Lentz
requested changes
Aug 2, 2023
mcallic2
approved these changes
Aug 2, 2023
rem1776
approved these changes
Aug 2, 2023
| @@ -1366,13 +989,13 @@ function get_axis_time (Time, units) result (atime) | |||
|
|
|||
| call get_time (Time, sec, day) | |||
| if (units(1:3) == 'sec') then | |||
| atime = float(sec) + 86400.*float(day) | |||
There was a problem hiding this comment.
was this float intrinsic casting to r4 with a default r8 compile? or was it r8? i think either way the static value would cause implicit casting to the bigger kind, but might be worth double checking.
There was a problem hiding this comment.
Good question! It's not implicitly casted according to the compilation log, but it's a private function and when called, aka xtime=get_axis_time(arguments), xtime is a r8_kind so I think we're safe here.
rem1776
added a commit
that referenced
this pull request
Sep 20, 2023
BREAKING CHANGE: In coupler_types.F90, `coupler_nd_field_type` and `coupler_nd_values_type` have been renamed to indicate real kind value: `coupler_nd_real4/8_field_type` and `coupler_nd_real4/8_values_type`. The `bc` field within `coupler_nd_bc_type` was modified to use r8_kind within the value and field types, and an additional field added `bc_r4` to use r4_kind values. Includes: * feat: eliminate use of real numbers for mixed precision in `block_control` (#1195) * feat: mixed precision field_manager (#1205) * feat: mixed precision random_numbers_mod (#1191) * feat: mixed precision time_manager reals to r8 and clean up (#1196) * feat: mixed Precision tracer_manager (#1212) * Mixed precision monin_obukhov (#1116) * Mixed precision: `monin_obukhov` unit tests (#1272) * mixed-precision diag_integral_mod (#1217) * mixed precision time_interp (#1252) * mixed precision interpolator_mod (#1305) * Mixed precision astronomy (#1092) * Mixed precision `data_override_mod` (#1323) * mixed precision exchange (#1341) * coupler mixed precision (#1353) * Mixed precision topography_mod (#1250) --------- Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains mixed mode updates to diag_integral_mod.
All private functions takes in r8_kind arguments.
All input real arguments are converted to r8_kind.
All real mathematical operations are carried out with r8_kind precision