Yaml update #1269
Merged
Yaml update #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
requested changes
Jul 6, 2023
ganganoaa
reviewed
Jul 7, 2023
thomas-robinson
requested changes
Jul 12, 2023
diag_manager/README.md
Outdated
Comment on lines
65
to
71
| - **file_name** is a string that defines the name of the file. Do not add ".nc" and "tileX" to the filename as this will be handled by FMS. | ||
| - **freq** is a string that defines the frequency and the units that data will be written | ||
| - The acceptable values for freq are: | ||
| - =-1: output at the end of the run only | ||
| - =0: output every timestep | ||
| - \>0: output frequency and units (with a space between the frequency number and units e.g 24 hours) | ||
| - The acceptable values for units are seconds, minutes, hours, days, months, years. |
There was a problem hiding this comment.
If -1 and 0 don't need units, then this section should be a little bit clearer. It should specifically include the units with the value and explicitly state that units are not needed for -1 and 0.
- The acceptable values for freq are:
- =-1: output at the end of the run only
- =0: output every timestep
- >0 units: output frequency and units (with a space between the frequency number and units e.g 24 hours)
Values of -1 or 0 do not require units.
thomas-robinson
approved these changes
Jul 13, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
documentation update
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
documentation update
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the need for
freq_units,new_file_freq_units, andfile_duration_unitsby allowingfreq,new_file_freq, andfile_durationto accept both.The tests and the documentation were also updated.
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses