-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write buffer prep #1311
Write buffer prep #1311
Conversation
@@ -287,6 +292,16 @@ subroutine add_field_and_yaml_id (this, new_field_id, yaml_id) | |||
endif | |||
end subroutine add_field_and_yaml_id | |||
|
|||
!> \brief Adds a field and yaml ID to the file | |||
subroutine add_buffer_ids (this, buffer_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this routine is a bit misleading. It only adds one ID, but ids
is plural in the routine name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Adds the field id and yaml id to the output_buffer object (this is needed so that we can get information about the variable when writing for the variable)" |
1 similar comment
"Adds the field id and yaml id to the output_buffer object (this is needed so that we can get information about the variable when writing for the variable)" |
We are looping through the buffer_ids for the file. The field_ids in the diag file object do not necessary correspond to the buffer_ids (i.e buffer_ids(i) may not be the buffer for field_ids(i)). They were added to the file as the fields were registering/data was sent. |
* Adds the buffer ids to the diag file object in the register call * add functionality to get the size of the subaxis * Add the field id and the yaml id to the buffer object (with getter and setter functions)
* Adds the buffer ids to the diag file object in the register call * add functionality to get the size of the subaxis * Add the field id and the yaml id to the buffer object (with getter and setter functions)
Description
To prepare for the write_buffer update:
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheck
passes