Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default missing values for missing values handling in various codes #14

Closed
wants to merge 3 commits into from

Conversation

btsuang
Copy link

@btsuang btsuang commented Jan 31, 2015

I am writing code for reading World Ocean Data. The data sets have missing values. I found in various codes. The missing values can be varied from code to code. Therefore, default missing values for real (real_missing) and for integer (int_missing) are suggested, here, in the FMS. Then, programmers can be shared with the same missing value.

@underwoo
Copy link
Member

underwoo commented Feb 3, 2015

Thank you for your pull request. However, we will not be able to accept this pull request. As there are many components that use the constants_mod module and many different files each of which use a different 'default' missing value. Although I agree a "default" would be beneficial, the values set should follow one set by one of the conventions (e.g. the CF convention, CMOR, the NetCDF fill parameters, etc.).

@underwoo underwoo closed this Feb 3, 2015
underwoo added a commit that referenced this pull request Jun 1, 2016
diag_manager would increase the number of attributes for a field when attempting to prepend new values. This fixes the issue.

Fixes #14
colingladueNOAA pushed a commit that referenced this pull request Mar 13, 2020
Merge in updates from FMS master branch to my fork
danholdaway added a commit to JCSDA/FMS that referenced this pull request Oct 16, 2020
thomas-robinson pushed a commit that referenced this pull request Jun 15, 2022
* Remove OVERLOAD_R8 directives regarding send_data_*d_r8 subroutines
* Add Doxygen comments to constants4.F90
climbfuji pushed a commit to climbfuji/FMS that referenced this pull request Apr 23, 2024
…e-heap-arrays

Fix Intel 19+MOM issue with debug
uramirez8707 pushed a commit to uramirez8707/FMS that referenced this pull request May 21, 2024
Add SHiELD atmos_model.F90 as an option
uramirez8707 pushed a commit to uramirez8707/FMS that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants