Field manager namelist #1412
Merged
Field manager namelist #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
requested review from
bensonr,
thomas-robinson and
rem1776
as code owners
bensonr
reviewed
Nov 17, 2023
field_manager/field_manager.F90
Outdated
| @@ -829,7 +850,7 @@ end subroutine new_name | |||
| !! needed within various modules. The field manager does not | |||
| !! initialize any of those schemes however. It simply holds the | |||
| !! information and is queried by the appropriate module. | |||
| subroutine field_manager_init(nfields, table_name) | |||
| subroutine field_manager_init_legacy(nfields, table_name) | |||
There was a problem hiding this comment.
I would prefer field_manager_init_field_table_original or something like that. Legacy is not descriptive enough.
There was a problem hiding this comment.
renamed to read_field_table_legacy and read_field_table_yaml
rem1776
approved these changes
Dec 13, 2023
thomas-robinson
approved these changes
Dec 14, 2023
bensonr
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a namelist to specify whether or not use the yaml tables (
use_field_table_yaml)The code crashes if
use_field_table_yaml = . true.and are not compiling with yaml.The code crashes if both versions of the tables are present
Adds units test to test all the options
Fixes #1313
How Has This Been Tested?
CI
Checklist:
make distcheckpasses