Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to finish the reduction methods at the right time #1459

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

uramirez8707
Copy link
Contributor

Description

  • Adds next_output to the output buffer object and subroutines to determine when to finish the reduction and to set it (this is used with the time)
  • Adds logic to diag_manager_end so that it can do one last write if it is time to to
  • Refactors write_field_data to take in one field/buffer instead of an array
  • Adds getters for next_output and next_next_output

Fixes # (issue)

How Has This Been Tested?
Before this update, there were answers changes such as

19790101.aerosol_daily_cmip.tile1.nc
DIFFER : VARIABLE : loadoa : POSITION : [0,0,0] : VALUES : 8.4246e-07 <> 8.24577e-07
DIFFER : VARIABLE : loadsoa : POSITION : [0,0,0] : VALUES : 2.4235e-07 <> 2.21925e-07
DIFFER : VARIABLE : loadso4 : POSITION : [0,0,0] : VALUES : 1.51636e-06 <> 1.54552e-06
DIFFER : VARIABLE : loadpoa : POSITION : [0,0,0] : VALUES : 6.0011e-07 <> 6.02652e-07

With this update they know reproduce.
This was tested with one year long AM4 experiments.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit f71405a into NOAA-GFDL:dmUpdate Feb 13, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants