Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hdf5 compiler check #1493

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix hdf5 compiler check #1493

merged 2 commits into from
Apr 30, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Apr 23, 2024

Description
Changes the configure check used to determine if a bug in hdf5 is present. Before it was using nf90_open which wouldn't work on certain systems.

Fixes #1492

How Has This Been Tested?
tested on gaea, amd box, and my laptop

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

configure.ac Show resolved Hide resolved
bensonr
bensonr previously approved these changes Apr 23, 2024
@rem1776
Copy link
Contributor Author

rem1776 commented Apr 24, 2024

This needed one other change for distcheck to pass. I also ran into a separate issue with the monin test script when i was testing this on different systems so I just included the fix here, just needed to force the rm so it wouldn't hang.

@rem1776 rem1776 merged commit 648cbcf into NOAA-GFDL:main Apr 30, 2024
18 of 20 checks passed
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure fails on gaea
2 participants