Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modern diag manager: Correctly uses the weight argument from send_data #1513

Merged
merged 4 commits into from
May 9, 2024
Merged

Modern diag manager: Correctly uses the weight argument from send_data #1513

merged 4 commits into from
May 9, 2024

Conversation

uramirez8707
Copy link
Contributor

Description

  • Passes in the weights to the subroutines that does the sum
  • Adds test
  • Changes the number of PEs that checks the diurnal output from 6 to 1

Fixes #1512

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 changed the title Weight down Modern diag manager: Correctly uses the weight argument from send_data May 7, 2024
thomas-robinson
thomas-robinson previously approved these changes May 9, 2024
View reviewed changes
@rem1776 rem1776 merged commit e2fa28a into NOAA-GFDL:main May 9, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson thomas-robinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modern diag_manager: The weight argument is not passed into reduction method functions
3 participants
@uramirez8707 @thomas-robinson @rem1776