Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $CMAKE_INSTALL_LIBDIR instead of hardcoding "lib" #1589

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Use $CMAKE_INSTALL_LIBDIR instead of hardcoding "lib" #1589

merged 1 commit into from
Sep 10, 2024

Conversation

harshula
Copy link
Contributor

Since GNUInstallDirs (https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html) is already included, we could use $CMAKE_INSTALL_LIBDIR instead of hardcoding lib.

During my testing $CMAKE_INSTALL_LIBDIR expanded to lib64, not lib:

$ ls /opt/release/linux-rocky8-x86_64/intel-2021.2.0/fms-git.use-cmake-install-libdir_0-git.3289-o47ywsb444ovhjfysqu2jqgzbe7szfrk/
include_r4  lib64

Is lib hardcoded to avoid the library being installed in lib64? If not, please consider this patch.

@harshula
Use $CMAKE_INSTALL_LIBDIR instead of hardcoding "lib"
151db1b 
* Also, use $CMAKE_INSTALL_BINDIR.
@harshula harshula mentioned this pull request Sep 10, 2024
Draft
climbfuji
climbfuji approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please, thanks!

@rem1776 rem1776 merged commit 44a211a into NOAA-GFDL:main Sep 10, 2024
28 checks passed
@harshula harshula deleted the use-cmake-install-libdir branch September 11, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@climbfuji climbfuji climbfuji approved these changes

@bensonr bensonr bensonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshula @bensonr @climbfuji @rem1776