Ascii io

[GFDL-Eric]

Description
Implementation of the ascii_read routine in fms2_io. This requires the transfer of several routines from mpp_io ans fms_io to fms2_io. Also includes a change in data_override to account for this movement.

Fixes lack of fms2_io ascii_io routines

How Has This Been Tested?
Includes a sample test of the routine, further testing when the suite of models is tested.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included
• make distcheck passes

[GFDL-Eric]

Honestly no, and in truth this test could use some fleshing out (right now it's basically there to test if the read crashes, not to ensure that the read successfully "read" the file).

…

On Fri, Mar 12, 2021 at 10:25 AM Jess ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test_fms/fms2_io/test_read_ascii_file.F90 <#706 (comment)>: > +program test_read_ascii_file + + use mpp_mod, only : mpp_init + use mpp_mod, only : mpp_error, FATAL, NOTE + use fms2_io_mod, only : fms2_io_init, ascii_read + + character(len=:), dimension(:), allocatable :: test_array !< Content array + character(len=256) :: filename !< Name of ascii file to be read + character(len=256) :: filename2 !< Name of alternative ascii file to be read + character(len=256) :: line !< Content of a line of the read ascii file + integer :: num_lines !< Number of lines in the ascii file + integer :: stat !< IOSTATUS from the read method + integer, allocatable :: cur_pelist(:) !< PELIST is read into this variable + integer :: ierr !< used by MPI_FINALIZE + +! namelist /test_read_ascii_file_nml/ test_numb Is there a reason to keep the commented-out tests? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#706 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3MSXPNFTJDHZTXBQB3MCLTDIP5XANCNFSM4ZAYVUDA> .

[GFDL-Eric]

I'm not sure how to resolve the "change requested" issue?

[rem1776]

@GFDL-Eric That should go away once Tom reviews it again