Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diag_yaml update #901

Merged
merged 5 commits into from
Feb 25, 2022
Merged

diag_yaml update #901

merged 5 commits into from
Feb 25, 2022

Conversation

uramirez8707
Copy link
Contributor

Description
Fix issue checking if frequency is valid.
Fix reading the diurnal and pow reduction

Fixes #900

How Has This Been Tested?
make check passes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 mentioned this pull request Feb 9, 2022
Closed
@uramirez8707 uramirez8707 changed the base branch from dmUpdate to main February 11, 2022 17:02
@uramirez8707 uramirez8707 changed the base branch from main to dmUpdate February 11, 2022 17:02
thomas-robinson
thomas-robinson requested changes Feb 15, 2022
View reviewed changes
diag_manager/fms_diag_yaml.F90 Outdated Show resolved Hide resolved
@thomas-robinson thomas-robinson merged commit 8165679 into NOAA-GFDL:dmUpdate Feb 25, 2022
@uramirez8707 uramirez8707 mentioned this pull request Mar 3, 2022
Closed
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
diag_yaml update (NOAA-GFDL#901)
67b40a6 
* Fix issue checking if frequency is valid, fix reading the diurnal and pow reduction

* Corrects error message

* changes logic to make more sense
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
diag_yaml update (NOAA-GFDL#901)
3409cc4 
* Fix issue checking if frequency is valid, fix reading the diurnal and pow reduction

* Corrects error message

* changes logic to make more sense
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
fix: diag_yaml object fix frequency and reading reductions (NOAA-GFDL…
4175073 
…#901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-robinson thomas-robinson thomas-robinson approved these changes

@bensonr bensonr Awaiting requested review from bensonr

@wrongkindofdoctor wrongkindofdoctor Awaiting requested review from wrongkindofdoctor

@rem1776 rem1776 Awaiting requested review from rem1776

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uramirez8707 @thomas-robinson