-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base time #937
Merged
Merged
Base time #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
base_time, base_year, base_month, base_day, base_hour, base_minute, base_second
are PUBLIC module variables, that can be changed at any point. They are set in diag_table_mod when the diag_table is read.Note: The base_time IS used in model code, in places like:
https://github.com/NOAA-GFDL/atmos_phys/blob/80d0a701d9772e23f44e6163cfd22ec0d762d0d9/atmos_param/radiation/radiative_gases/radiative_gases.F90#L2258
This PR:
get_base_time
is made public by diag_manager to reproduce previous behavior:base_time_set
, prevents users from changing themHow Has This Been Tested?
CI Passes which includes a test for this
c96L33_am4p0 experiment still reproduces with this branch (as is) intel prod-openmp, debug
Checklist:
make distcheck
passes