Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish register diag #984

Merged
merged 7 commits into from
Jun 15, 2022

Conversation

uramirez8707
Copy link
Contributor

Description
This PR:

  • Changes the fms_register_diag_field_obj arguments by adding diag_field_indices, so that the diag_field yaml can be added to the diag_obj, and makes axes public, so that this interface can be used for scalar and array variables. This breaks the test_diag_object_container, so the test is no longer compiled. This will need to be removed later.
  • Sets up an array of subaxis_t objects to store any sub axis for sub_regions
  • Adds the domain and sub_axis info to the diag_file_obj
  • Completes (almost!) the register_diag_field work! Just need to fill in the var_reg, var_ids and var_index part of the diag_file object and the sub_regional stuff still needs to be set up

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson thomas-robinson merged commit 3af3360 into NOAA-GFDL:dmUpdate Jun 15, 2022
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants