Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass flux routines if do_flux=.F. #142

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

JosephMouallem
Copy link
Contributor

Complementary to #134, add do_flux flag for routines coupler_generate_sfc_xgrid and flux_exchange_init.
Since no fluxes are being shared between components, there is no need for these routines.
With an appropriate namelist setup, full coupler shield can run with no coupled mosaic files.

@rem1776 rem1776 requested review from bensonr and rem1776 August 7, 2024 20:21
@rem1776
Copy link
Contributor

rem1776 commented Aug 7, 2024

@JosephMouallem There are some calls to coupler_flux_init_finish_stocks in coupler main which calls the flux_init_stocks and flux_check_stocks routines from the flux exchange module. Should these get a similar update and only run if do_flux is true?

if (check_stocks >= 0) call coupler_flux_init_finish_stocks(Time, Atm, Land, Ice, Ocean_state, &
coupler_clocks, init_stocks=.True.)

if( check_stocks >=0 ) call coupler_flux_init_finish_stocks(Time, Atm, Land, Ice, Ocean_state, &
coupler_clocks, finish_stocks=.True.)

@JosephMouallem
Copy link
Contributor Author

Hi @rem1776, they currently dont crash the model and print 0 values for the stocks in the log file, we can add do_flux to make things cleaner.

Copy link
Contributor

@rem1776 rem1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JosephMouallem Thanks for making those changes!

@rem1776 rem1776 merged commit e357d8f into NOAA-GFDL:main Aug 30, 2024
2 checks passed
@JosephMouallem JosephMouallem deleted the bypass_xgrid_flux_init branch November 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants