Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wgrs to zero-size allocation #315

Closed

Conversation

grantfirl
Copy link

Description

This small change is part of a larger project to pass NCO's requirements of compiling the UFS with the -check all compiler option. Previously conditionally-allocated arrays in fv3atm (particularly GFS_typedefs and CCPP_typedefs) need to always be allocated (at least to zero size) in order to NOT run into runtime errors with the -check all option (used in DEBUG mode). The only change needed in this repo is related to the vertical velocity (wgrs) variable that was added to physics a while back for the lightning algorithm.

ufs-community/ufs-weather-model#2023

How Has This Been Tested?

This was tested using UFS regression tests on Hera with the -check all compiler option added for Intel.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@grantfirl
Copy link
Author

This is replaced by NOAA-EMC#86, which is targeted at the RRFS release branch. This change will likely NOT need to go to dev/emc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants