-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop branch into main branch #295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add CM4 diag table to repo * swap diag table docx with trimmed-down text file
- install mamba (https://github.com/mamba-org/mamba) first, and use it to speed up installation of all other conda envs, including the one for synthetic data. Note that currently only the dependency solve is accelerated (mamba-org/mamba#633), but this is sufficient for a large improvement over conda. - Remove the --mamba flag from the conda_env_setup.sh script's arguments, as this was taken out in #166.
Improve mamba usage in CI
* Initial commit of code from Arielle Catalano * Correct extension for settings.jsonc * Add freq=day to varlist for backwards compatibility * Commit conda env for temp_extremes_distshape * Commit conda env for temp_extremes_distshape * Run temp_extremes_distshape in python_base instead of custom env * adding new POD, documentation, and obs subset code * Fix case of CF variable names * Set Matplotlib backend in settings.jsonc * Propagate gs command-line flags to GFDL branch * Temporary debugging statements * Update temp_extremes_distshape settings.jsonc * Update format of settings.jsonc * Add missing 'log' argument to GFDL data source attribute classes * log InitVar must be 1st arg to __post_init__ due to inheritance * Restore missing class attributes to GFDL CMIP6 DataSources * Convert .pdf documentation to .rst * Fix obs filenames and templating in html * Write temp files to WK_DIR, not POD_HOME temp_extremes_distshapes code was writing temporary parameter .json files to $POD_HOME, which should be read-only. Change root directory for writing all these files from $POD_HOME to $WK_DIR. * Correct variable names * Correct method for colorbar tick labels * Handle case where no contours are labeled * Correct cartopy longitude set_extents * Correct Moments_plot colorbar positioning * Add documentation for set_extent() fix * add test jsonc files for temp_extremes_distshape CMIP * added test yaml file just for temp_extremes_distshape * add call create the inputdata directory before untarring the obs_data file to the test yaml * add checks to test yaml * Specify full paths in ubuntu set3 jsonc * remove comments from test jsonc files change CASENAME to match the format output by updated synthetic data generator in the set3 test jsonc files * update mdtf_tests.yml to include this branch for testing before PR is submitted * remove this branch from mdtf_tests.yml * Switch paths back to relative locations in ubuntu set 3 jsonc * change model name to synthetic in github actions set 3 jsonc files * changed ls to just show temp_extremes_distshape obs_data directory * fixed path in ls * added print statements for path checks * add pring statement to group_relative_links * removed print statements from output_manager and verify_links * changed test yml to experimental status and added ls for wkdir after POD runs * fix typo * remove some test lines in test_cmip.yml * change exit status for missing files to 0 for debugging in verify_links.py * remove debugging in verify_links comment out pod.deactivate call in verify_links for debugging * removed PS from the output figure path in TempExtDistShape_CircComps_usp.py bc file is png not postscript * changed ls to wildcard in test_cmip.yml * dump output log to terminal * define output figure path as separate variable with os.path.join in TempExtDistShape_ShiftRatio_util.py * revert changes to path name * change set3 env to python3 * change cartopy to version 0.19 in env_python3_base.yml * revert debugging mods to output_manager.py * remove extraneous checks from mdtf_tests.yml test yaml with MDTF_base environment for set 3 tests * replace _MDTF_python3_base with _MDTF_base in mdtf_tests.yml set 3 tests Co-authored-by: Thomas Jackson <tom.jackson314@gmail.com> Co-authored-by: tsjackson-noaa <thomas.jackson@noaa.gov> Co-authored-by: Arielle Catalano <acat2@ggr-ch-412-ac.psu.ds.pdx.edu>
…r options can come last
Fixes broken CI.
Improvements to documentation on CLI settings
* create pod * main script update output dir still need to change to env var * altrimetry observational data preprocessing code process the daily data from CMEMS to monthly data * calculate the wind stress curl for model and obs * unfinished OMIP model variable is not in the example model * small function to show used memory * calculate the gridded area for observational data * function designed for xr.Dataset only used the da_linregress func in the main script * create naming convension for OMIP CESM2 * setting of the config file * update to relative path to with respect to $CODE_ROOT * update the file name to MDTF $CASENAME format * include the documentation of the tool * change variable name to match fieldlist * update the jsonc files still cannot run * remove unused function and repeating constant * remove redundent import and multiple defined var * clear unused function * change comment * correct start year and end year to string * change the OUTPUT_DIR setting * correct the comma at the end of the list * fixed the output dir blank * syntex error corrected * correct the jsonc format * add print out * correct the environment variable * removed commented part that is not used * include kwarg for earth radius for flexibility * update the html format for this particular diag * corrcet error and add references * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * updated to f-string format for readability * setting file works in version 2 (bk) * add new format for version 3 setting file * unfinished changes in the main script * add observational data access info * use the version2 format for now * add the observational data info in the docstring * save the new version3 format * update preprocessing code remove the open_mfdataset function since it require dask to be installed * update from main branch * testing tropical sea level diag * update to the latest format * update to the latest format and some fix suggested by Tom * remove the previous version files * Updates to AVISO processing script - Implement faster os.scantree() for finding files - Cleaned up xarray Dataset vs. DataArray objects - Replaced for-loop with list comprehension - Save output in 32-bit floats to save data volume - Carry source variable attributes to output NetCDF file * create pod * main script update output dir still need to change to env var * altrimetry observational data preprocessing code process the daily data from CMEMS to monthly data * calculate the wind stress curl for model and obs * unfinished OMIP model variable is not in the example model * small function to show used memory * calculate the gridded area for observational data * function designed for xr.Dataset only used the da_linregress func in the main script * create naming convension for OMIP CESM2 * setting of the config file * update to relative path to with respect to $CODE_ROOT * update the file name to MDTF $CASENAME format * include the documentation of the tool * change variable name to match fieldlist * update the jsonc files still cannot run * remove unused function and repeating constant * remove redundent import and multiple defined var * clear unused function * change comment * correct start year and end year to string * change the OUTPUT_DIR setting * correct the comma at the end of the list * fixed the output dir blank * syntex error corrected * correct the jsonc format * add print out * correct the environment variable * removed commented part that is not used * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * updated to f-string format for readability * include kwarg for earth radius for flexibility * update the html format for this particular diag * corrcet error and add references * setting file works in version 2 (bk) * add new format for version 3 setting file * unfinished changes in the main script * add observational data access info * use the version2 format for now * add the observational data info in the docstring * save the new version3 format * update preprocessing code remove the open_mfdataset function since it require dask to be installed * update from main branch * testing tropical sea level diag * update to the latest format * update to the latest format and some fix suggested by Tom * remove the previous version files * Updates to AVISO processing script - Implement faster os.scantree() for finding files - Cleaned up xarray Dataset vs. DataArray objects - Replaced for-loop with list comprehension - Save output in 32-bit floats to save data volume - Carry source variable attributes to output NetCDF file * Fixed tropical sea level jsonc syntax errors - removed trailing comma - removed "dimensions_ordered": true, line * Updates default_tests.jsonc - Renamed "CESM2" --> "CESM" - Removed hard-coded anaconda paths * Updates to sea level POD settings file - Simplified settings for debugging - Renamed nlat/nlon to lat/lon - Commented out areacello for testing * Added sea level fields to NCAR and CMIP field lists - areacello, tauuo, tauvo, and zos * Seperate testing jsonc file for NCAR Synthetic - Making life easier for testing * Fix dimension elimination for 2D lat/lon coords * Make translated var axes check more permissive - cf-xarray mod needed to understand curvilinear coordinates; until that fix is in place, this check will fail for grids that have 2-dimensional coordinates - changed fatal exception to a warning - wrapped rest of the coordinate metadata checks inside an if-block * Updated tropical sea level pod settings file * Updated NCAR field list for sea level POD - now includes tauuo and tauvo * Updated year range for default case list * Updated to tropical sea level diagnostic script - Mostly edits to opening datasets * Bypass Dask parallelization - Not working; commented out for now. * Fixed indexing for tropical sea level curl calc - indicies appear to be missing for central differences * Modified model read statements for tropical sl POD - More native Xarray logic * Patches for obs. data time issues - impacts tropical sea level pod - addresses mismatch between time axis and data length - hard-coded date ranges for now; needs to be generalized * Specify dim names before regional averaging - impacts tropical sea level pod - needs to be generalized for all multidimensional coordinate grids * incorporate changes from John * using CESM2 testing * used the xr_ufunc with dask disabled load the dataset before function call * multiple updates 1. allow xaxis and yaxis name option in pod_env_var 2. allow selecting different obs start year and end year in pod_env_var 3. fix the trend plot in ylim and xlim setting * add new pod_env_var for obs year and axis name * fixed the dimension not matching in model cal * function calculate wind stress curl for obs * function calculate cell area in obs * process predefined obs mean trend and season sig * linear regression for linear trend calculation * add the predefine flag for obs to speed up cal * add the predefined obs option in the main.py * pylint and black format corrected * add transpose in functions to make sure dim order * address some LGTM error * create pod * main script update output dir still need to change to env var * altrimetry observational data preprocessing code process the daily data from CMEMS to monthly data * calculate the wind stress curl for model and obs * unfinished OMIP model variable is not in the example model * small function to show used memory * calculate the gridded area for observational data * function designed for xr.Dataset only used the da_linregress func in the main script * create naming convension for OMIP CESM2 * setting of the config file * update to relative path to with respect to $CODE_ROOT * update the file name to MDTF $CASENAME format * include the documentation of the tool * change variable name to match fieldlist * update the jsonc files still cannot run * remove unused function and repeating constant * remove redundent import and multiple defined var * clear unused function * change comment * correct start year and end year to string * change the OUTPUT_DIR setting * correct the comma at the end of the list * fixed the output dir blank * syntex error corrected * correct the jsonc format * add print out * correct the environment variable * removed commented part that is not used * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * Update diagnostics/tropical_pacific_sea_level/doc/tropical_pacific_sea_level.rst Co-authored-by: John Krasting <John.Krasting@noaa.gov> * updated to f-string format for readability * include kwarg for earth radius for flexibility * update the html format for this particular diag * corrcet error and add references * setting file works in version 2 (bk) * add new format for version 3 setting file * unfinished changes in the main script * add observational data access info * use the version2 format for now * add the observational data info in the docstring * save the new version3 format * update preprocessing code remove the open_mfdataset function since it require dask to be installed * update from main branch * testing tropical sea level diag * update to the latest format * update to the latest format and some fix suggested by Tom * remove the previous version files * Updates to AVISO processing script - Implement faster os.scantree() for finding files - Cleaned up xarray Dataset vs. DataArray objects - Replaced for-loop with list comprehension - Save output in 32-bit floats to save data volume - Carry source variable attributes to output NetCDF file * Fixed tropical sea level jsonc syntax errors - removed trailing comma - removed "dimensions_ordered": true, line * Updates default_tests.jsonc - Renamed "CESM2" --> "CESM" - Removed hard-coded anaconda paths * Updates to sea level POD settings file - Simplified settings for debugging - Renamed nlat/nlon to lat/lon - Commented out areacello for testing * Added sea level fields to NCAR and CMIP field lists - areacello, tauuo, tauvo, and zos * Seperate testing jsonc file for NCAR Synthetic - Making life easier for testing * Fix dimension elimination for 2D lat/lon coords * Make translated var axes check more permissive - cf-xarray mod needed to understand curvilinear coordinates; until that fix is in place, this check will fail for grids that have 2-dimensional coordinates - changed fatal exception to a warning - wrapped rest of the coordinate metadata checks inside an if-block * Updated tropical sea level pod settings file * Updated NCAR field list for sea level POD - now includes tauuo and tauvo * Updated year range for default case list * Updated to tropical sea level diagnostic script - Mostly edits to opening datasets * Bypass Dask parallelization - Not working; commented out for now. * Fixed indexing for tropical sea level curl calc - indicies appear to be missing for central differences * Modified model read statements for tropical sl POD - More native Xarray logic * Patches for obs. data time issues - impacts tropical sea level pod - addresses mismatch between time axis and data length - hard-coded date ranges for now; needs to be generalized * Specify dim names before regional averaging - impacts tropical sea level pod - needs to be generalized for all multidimensional coordinate grids * Revert "Make translated var axes check more permissive" This reverts commit d68769c. * fix the missing value casued by model lon range the model lon range for the synthetic is -270~90 the original code did not convert the long range to 0-360 which causes the model to pick region that does not exist in the synthetic data * Remove unused imports from createCMIP6CV.py * Delete default_tests_ncar_synthetic.jsonc * remove user modifications from default_tests.jsonc * remove duplicate variable entries from fieldlist_CMIP.jsonc * remove changes to xr_parser.py Co-authored-by: chiaweih@climate <chiaweih@email.arizona.edu> Co-authored-by: Chia-Wei Hsu <chiaweh2@users.noreply.github.com> Co-authored-by: Jess <20195932+wrongkindofdoctor@users.noreply.github.com>
* added modifiers.jsonc with entry for atmospheric height added modifiers att to core.VariableTranslator __init__ method added modifier att to data_model.DMDependentVariable class and the comments of classes that inherit it corrected modifier to modifiers * removed long_name att from modifiers.jsonc * added check for modfiers to DMDependentVariable __post_init method * change second temp_d index to entry.modifiers, remove invalid comment * changed argument axes_set to modfiers in translate, from_CF, and from_CF_name * added modifiers to NoTranslateFieldlist TranslateVarlistEntry, and changed axes_set to modifiers in from_CF, and from_CF_name * changed modifiers to modifier * change remaining axes_set arguments to modifier in core.py * changed modifier.jsonc to modifiers.jsonc in core.py * revert change in _ndim_to_axes_set name * added develop branch exit call changes to core.py * attempt to fix .strip .lower spec * change self.modifiers to self.modifier * add modifier att to TREFHT, tas, and t_ref in conventin jsonc files * fixed CMIP fieldlist * added modifier attribute to temperature variable in example settings.jsonc file * add core import and redefine variabletranslator call indata_model.py * remove space in description * added modifiers documentation to ref_settings.rst * add preliminary version of test_variable_translator_bad_modifier * move the fieldlist convention reads to its own method, and replace MDTFFramework.configure call to variable translator with VariableTranslator.read_convention * fix the variableTranslator and read_conventions calls * rework tests that call VariableTranslator to use read_conventions after initialization * added check that modifier is an empty string to from_CF routine removed extraneous parentheses from routines in core.py * refined modifier check to differentitate between 3d and 4d variable entries. Still needs work. * added variable dimension size and argument num_dims to from_CF * Changed default modifier arguments back to None in core.py routines changed from_CF to check if modifier is false before checking lut entries since empty strings and None types will evaluate to False * fixed changes in from_CF that got overwritten by develop branch sync * added atmos_height modifier attribute to tas in temp_extremes_distshape settings.jsonc file removed modifier assignment to frozenset in from_CF because it is a single string rather than a list * missed adding the file with the frozenset change in prior commit message * fix typo in data_model.py DMDependentVariable error message fix spacing for inline comments * fix issues with modifier test in test_core.py add a check for a correct modifier entry to modifier test * revert spacing change to data_manager.py * revert changes to default_tests.jsonc again * Update src/core.py Co-authored-by: John Krasting <John.Krasting@noaa.gov> Co-authored-by: John Krasting <John.Krasting@noaa.gov>
This requires PR #266 to be merged first.
* Update FRE wrapper (mtdf_gfdl.csh) Update the FRE wrapper script to use current flags. Do not load a python env module; instead run the same commands as the interactive wrapper script to invoke the site-installed conda env before running the package. Disable functionality to make a copy of output for hosting on an internal website, since updates aren't being made to Dora. Retain code for when this functionality is re-enabled. * More debugging statements in FRE wrapper * Pass through args in wrapper; set --convention default to GFDL * Add more detail on wrapper script to GFDL docs * Convention defaults for GFDL_PP, LocalFile data sources Set the default --convention assumed for SampleLocalFileDataSource to "CMIP", to be consistent with what's written in the documentation. Set the default --convention assumed for the GFDL_PP data source to "GFDL", since this is the most common use case (but not the only one). Mention this in the docs. Take logic to set this default value out of the mdtf_gfdl.csh wrapper script. * Better regex in FRE wrapper * Restore model component-specific options Allow --component and --chunk_freq flags to be passed to the GFDL_PP data source to restrict the data query to files with those attributes. Add functionality to the FRE wrapper script to handle the real use cases. Pass --multi_component to the wrapper to invoke "frepp mode" (multiple runs of the package on same data, as it's being output from postprocessing); pass --component_only to restrict the model component used. Update and expand the docs for these settings to explain all this. * Refine model component-specific logic in FRE flags Remove the --multi_component/--any_component flag from the mdtf_gfdl.csh wrapper, and replace it with --run_once. This is because the sensible default behavior for the wrapper hould be the opposite of what was previously implemented: the default scenario for when the package is called from FRE is the incremental/online processing use case ("scenario 3B" in the docs). Non-default use cases are when the package is invoked only once, after all needed data is postprocessed (scenario 3A), or when the user wants to manually restrict the operation to the given model components. These are invokes via the --run_once or --component_only flags in the wrapper script. * Update all references to GFDL site installation Remove all paths and references to the old GFDL site installation in oar.gfdl.mdteam and replace with their counterparts in the oar.gfdl.mdtf role account. * Fix .rst formatting bug in docs * More .rst tweaks * Tweaks to default data source convention specification Co-authored-by: Jess <20195932+wrongkindofdoctor@users.noreply.github.com>
* change 3 wind_speed to sfcWind in CMIP fieldlist * change 3D hus to huss in CMIP fieldlist hus is for 4D specific humidity, while huss is for 3D (near-surface) specific humidity.
* Initial commit of custom CSS for autodoc (only) Attempt to tweak spacing of elements in autodoc pages. Styling of rest of documentation site is unchanged. * Fix docstring 'Returns:' formatting * Docstring formatting fixes * Add manually written doc section to framework TOC * Tweak autodoc settings to remove unneeded output * Add more space, grouping between class docstrings * Improve mamba usage in CI - install mamba (https://github.com/mamba-org/mamba) first, and use it to speed up installation of all other conda envs, including the one for synthetic data. Note that currently only the dependency solve is accelerated (mamba-org/mamba#633), but this is sufficient for a large improvement over conda. - Remove the --mamba flag from the conda_env_setup.sh script's arguments, as this was taken out in #166. * Add temp extremes distshape to CI (#273) * Initial commit of code from Arielle Catalano * Correct extension for settings.jsonc * Add freq=day to varlist for backwards compatibility * Commit conda env for temp_extremes_distshape * Commit conda env for temp_extremes_distshape * Run temp_extremes_distshape in python_base instead of custom env * adding new POD, documentation, and obs subset code * Fix case of CF variable names * Set Matplotlib backend in settings.jsonc * Propagate gs command-line flags to GFDL branch * Temporary debugging statements * Update temp_extremes_distshape settings.jsonc * Update format of settings.jsonc * Add missing 'log' argument to GFDL data source attribute classes * log InitVar must be 1st arg to __post_init__ due to inheritance * Restore missing class attributes to GFDL CMIP6 DataSources * Convert .pdf documentation to .rst * Fix obs filenames and templating in html * Write temp files to WK_DIR, not POD_HOME temp_extremes_distshapes code was writing temporary parameter .json files to $POD_HOME, which should be read-only. Change root directory for writing all these files from $POD_HOME to $WK_DIR. * Correct variable names * Correct method for colorbar tick labels * Handle case where no contours are labeled * Correct cartopy longitude set_extents * Correct Moments_plot colorbar positioning * Add documentation for set_extent() fix * add test jsonc files for temp_extremes_distshape CMIP * added test yaml file just for temp_extremes_distshape * add call create the inputdata directory before untarring the obs_data file to the test yaml * add checks to test yaml * Specify full paths in ubuntu set3 jsonc * remove comments from test jsonc files change CASENAME to match the format output by updated synthetic data generator in the set3 test jsonc files * update mdtf_tests.yml to include this branch for testing before PR is submitted * remove this branch from mdtf_tests.yml * Switch paths back to relative locations in ubuntu set 3 jsonc * change model name to synthetic in github actions set 3 jsonc files * changed ls to just show temp_extremes_distshape obs_data directory * fixed path in ls * added print statements for path checks * add pring statement to group_relative_links * removed print statements from output_manager and verify_links * changed test yml to experimental status and added ls for wkdir after POD runs * fix typo * remove some test lines in test_cmip.yml * change exit status for missing files to 0 for debugging in verify_links.py * remove debugging in verify_links comment out pod.deactivate call in verify_links for debugging * removed PS from the output figure path in TempExtDistShape_CircComps_usp.py bc file is png not postscript * changed ls to wildcard in test_cmip.yml * dump output log to terminal * define output figure path as separate variable with os.path.join in TempExtDistShape_ShiftRatio_util.py * revert changes to path name * change set3 env to python3 * change cartopy to version 0.19 in env_python3_base.yml * revert debugging mods to output_manager.py * remove extraneous checks from mdtf_tests.yml test yaml with MDTF_base environment for set 3 tests * replace _MDTF_python3_base with _MDTF_base in mdtf_tests.yml set 3 tests Co-authored-by: Thomas Jackson <tom.jackson314@gmail.com> Co-authored-by: tsjackson-noaa <thomas.jackson@noaa.gov> Co-authored-by: Arielle Catalano <acat2@ggr-ch-412-ac.psu.ds.pdx.edu> * Abbreviate logger in function/method signatures * Set more prominent CSS highlight color * Expand docstrings for src/util * Commit manual doc for util subpackage * Stop sphinx-apidoc from importing unit tests * Fix mocking of external imports when docs are built * Sphinx CSS tweaks Increase item spacing, fix shading, add border for code literal blockquotes * Improve coverage of class attributes Set inherited-members to True to include inherited dataclass fields and simplify navigating class heirarchy. Define skip_members_handler() to remove docstrings of methods we don't want to include (eg from stdlib). * Update 'supporting modules' docstrings * Partial commit of updated docstrings for main modules * Fix documentation .rst syntax errors * Initial commit of remaining manually-generated internal API docs * Split up data source docs across multiple pages Include sphinx links to relevant docs in module summary docstrings. * More crossreferences in docs * Fix module docstrings Sphinx autosummary only includes first sentence of docstring, not first paragraph. Co-authored-by: Jess <20195932+wrongkindofdoctor@users.noreply.github.com> Co-authored-by: Thomas Jackson <tom.jackson314@gmail.com> Co-authored-by: Arielle Catalano <acat2@ggr-ch-412-ac.psu.ds.pdx.edu>
Incorporate common packages required to run mld (and other) PODs
* Change cf_time calendar logic * remove check for cftime calendar in tcoord.values The cftime calendar attribute is most likely present in other t_coord and ds features that are checked, so remove unnecessary assumption of calendar att in t_coord.values[0]
The metpy package will support incoming the ocn_flux_matrix POD and others that require it
* add test yaml for trop pac sl pod * updated tpsl test yaml * Fix branch name * Change mdtf_test_data version to 1.0.4 * change mdtf-test-data version to 1.0.4.post1 in test yaml * add tropical pacific sea level POD to set3 test yaml * fix branch name in test yaml * fix directory location in test data untar stage * change tauuo and tauvo standard names in settings file to match names in CMIP fieldlist * fix tauuo and tauvo standard_names in tpsl settings.jsonc * update mdtf_test_data version in mdtf_tests.yml add temp_extremes_distshape PODs back to set3 test jsonc files add trop_pac_sl obs data tarball fetch to mdtf_tests.yml * remove test_tpsl.yml from repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change, and link the associated issue (if applicable).
List any dependencies that are required for this change, including libraries and variables,
and their metadata (units, frequencies, etc...). Be sure to separate PRs and issues for new PODs and PODs currently under development.
Associated issue # (replace this phrase and parentheses with the issue number)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in enough detail that
someone can reproduce them. Include any relevant details for your test configuration
such as the Python version, package versions, expected POD wallclock time, and the
operating system(s) you ran your tests on.
Checklist:
conda_env_setup.sh