Remove Python venv setup from GitLab-CI rules #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab CI includes the internal testing suite (.testing) and included an explicit setup of the Python environment (`make work/local-env`). The rule has since been removed, and the command now fails. This patch removes those steps, since we no longer use Python in the tests. It also slightly reworks the reporting of test output. Instead of re-running `make test`, it uses the `make test.summary` rule to report the final result.
|
The regression suite was tested here: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17497 but it should be independently verified. |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #252 +/- ##
============================================
- Coverage 37.18% 37.17% -0.02%
============================================
Files 263 263
Lines 73198 73221 +23
Branches 13637 13638 +1
============================================
+ Hits 27217 27218 +1
- Misses 40956 40978 +22
Partials 5025 5025
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adcroft
approved these changes
Nov 22, 2022
|
Unfortunately I don't think this PR actually solved the underlying issue. It appears to be a random failure where re-running the test fixes the problem. This needs further investigation. Note that this is exclusive to the GitLab testing on Gaea and should not affect anyone else. |
This was referenced Apr 6, 2023
marshallward
pushed a commit
that referenced
this pull request
Oct 25, 2023
Output relevant fields when diff or visc < 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab CI includes the internal testing suite (.testing) and included an explicit setup of the Python environment (
make work/local-env). The rule has since been removed, and the command now fails.This patch removes those steps, since we no longer use Python in the tests.
It also slightly reworks the reporting of test output. Instead of re-running
make test, it uses themake test.summaryrule to report the final result.