Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.testing: Fix concurrency errors in tc4 rules #255

Merged
merged 1 commit into from
Nov 25, 2022

Commits on Nov 24, 2022

  1. .testing: Fix concurrency errors in tc4 rules

    This patch fixes two issues in the preprocessing of tc4.
    
    * ocean_hgrid.nc is marked as a dependency of gen_data
    * Multiple ouputs are handled more safely in the Makefile
    
    Expanding on the second point: We were directing one rule to produce two
    output files, which resulted in the rule being run twice when invoked in
    parallel (make -j).
    
    This has been replaced with the recommended solution for handling
    concurrent outputs: use one to generate both, and connect the second to
    the first with a separate rule.
    
    I have also generalized the `make` command in the .testing Makefile.
    
    This should address (and hopefully fix) some intermittent errors in the
    .testing build on Gaea.
    marshallward committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    7a962e5 View commit details
    Browse the repository at this point in the history