Document units in 8 lat_param or diag modules #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #256 +/- ##
============================================
- Coverage 37.13% 37.12% -0.01%
============================================
Files 263 263
Lines 73434 73434
Branches 13674 13674
============================================
- Hits 27268 27265 -3
- Misses 41142 41145 +3
Partials 5024 5024
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adcroft
reviewed
Nov 28, 2022
Hallberg-NOAA
force-pushed
the
lat_param_doc_units
branch
2 times, most recently
from
60c1080
to
cf77c27
Compare
|
This PR has now been amended to eliminate the |
Documented numerous internal variables and their units in 3 lateral parameterization modules (MOM_hor_visc, MOM_lateral_mixing_coeffs, MOM_MEKE_types) and the write_cputime module. In addition, the units of a number of internal variables in the MOM_sum_output module and arguments to call_tracer_stocks were added to their descriptions in comments. This commit includes the addition of units arguments in 9 unlogged get_param calls, comments describing why parameters are not rescaled, and the rescaling of MAXVEL in hor_visc_init. A number of spelling errors were also corrected in comments. All answers and output are bitwise identical.
Hallberg-NOAA
force-pushed
the
lat_param_doc_units
branch
from
cf77c27
to
945b441
Compare
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17654 ✔️ |
marshallward
approved these changes
Dec 12, 2022
This was referenced Apr 6, 2023
marshallward
pushed a commit
that referenced
this pull request
Oct 25, 2023
Add option to apply non-local momentum flux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented numerous internal variables and their units in 3 lateral parameterization modules (MOM_hor_visc, MOM_lateral_mixing_coeffs, MOM_MEKE_types) and the write_cputime module. In addition, the units of a number of internal variables in the MOM_sum_output module and arguments to call_tracer_stocks were added to their descriptions in comments. This commit includes the addition of units or scale=1.0 arguments in 9 unlogged get_param calls. A number of spelling errors were also corrected in comments. All answers and output are bitwise identical.