+Add 11 units arguments to get_param calls #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #258 +/- ##
=========================================
Coverage 37.12% 37.12%
=========================================
Files 263 263
Lines 73434 73434
Branches 13674 13674
=========================================
Hits 27266 27266
Misses 41143 41143
Partials 5025 5025
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
force-pushed
the
logged_param_units
branch
from
d4ebd3a
to
3174569
Compare
|
This commit was revised to eliminate the |
Hallberg-NOAA
force-pushed
the
logged_param_units
branch
from
3174569
to
55af507
Compare
Add units arguments to 10 get_param calls in 7 files. Also changed comments describing the various units that might be used for geoLat or geoLon variables in the ocean_grid_type to use standard syntax. The added units arguments lead to some minor differences in MOM_parameter_doc files, but all answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
logged_param_units
branch
from
55af507
to
1edf11f
Compare
marshallward
approved these changes
Dec 12, 2022
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17672 ✔️ 🟡 |
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add units arguments to 11 get_param calls in 8 files, and added scale=1.0 arguments to 3 get_param calls in solo_driver/MOM_driver.F90, along with comments explaining why these time variables are not being rescaled. Also changed comments describing the various units that might be used for geoLat or geoLon variables in the ocean_grid_type to use standard syntax. The added units arguments lead to some minor differences in MOM_parameter_doc files, but all answers are bitwise identical.