Patch makedep to include C in "externals" #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #274 +/- ##
=========================================
Coverage 37.12% 37.12%
=========================================
Files 263 263
Lines 73434 73434
Branches 13674 13674
=========================================
Hits 27266 27266
Misses 41144 41144
Partials 5024 5024 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This is a first pass to refactoring the makedep script, primarily to make it PEP8 compliant.
Applying makedep to a single shot build of FMS+MOM6 (i.e. skipping the libFMS.a) I found the list of objects was incomplete because the C files were not covered by the module dependencies. makedep figures out the Fortran module dependencies and then has a list of "externals" to cover all the files that don't provide modules. "externals" are always compiled, in lieu of flinting the source code. This commit simply adds all the C object files to the list of externals. When building a library, the module dependencies are ignore and everything gets built, which is why this gap was not seen before.
Fixes all remaining PEP8 violations in ac/makedep (using line length = 132).
adcroft
force-pushed
the
patch-makedep-c-externals
branch
from
f387590
to
ca6264e
Compare
marshallward
approved these changes
Dec 9, 2022
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying makedep to a single shot build of FMS+MOM6 (i.e. skipping the libFMS.a) I found the list of objects was incomplete because the C files were not covered by the module dependencies. makedep figures out the Fortran module dependencies and then has a list of "externals" to cover all the files that don't provide modules. "externals" are always compiled, in lieu of flinting the source code. The main commit simply adds all the C object files to the list of externals. When building via a library, the module dependencies are ignored and everything gets built, which is why this gap was not seen before.
Two other commits refactor the script to follow PEP8 (the first from @marshallward).