+Add 6 runtime parameters for OBC testcase initialization modules #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
documentation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #290 +/- ##
============================================
- Coverage 37.07% 37.07% -0.01%
============================================
Files 263 263
Lines 73620 73623 +3
Branches 13720 13720
============================================
- Hits 27295 27294 -1
- Misses 41287 41292 +5
+ Partials 5038 5037 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This looks reasonable to me and indeed the answers don't change. However, this diff shows up in a rescaling test: Note the "mean temp". |
Added the new runtime parameter DUMBBELL_T_LIGHT to specify the previously hard-coded dimensional parameters in the dumbbell_initialization module. Also used G%x_ax_unit_short to describe the units of the DUMBBELL_LEN. By default all answers are bitwise identical, but there is a new entry in the MOM_parameter_doc.all files for the dumbbell test case.
Added the new runtime parameters KELVIN_WAVE_PERIOD, KELVIN_WAVE_SSH_AMP and KELVIN_WAVE_INFLOW_AMP to specify the previously hard-coded dimensional parameters in the Kelvin_initialization module. This change includes the addition of 3 new elements in the Kelvin_OBC_CS type. By default all answers are bitwise identical, but there are new entries in the MOM_parameter_doc.all files for configurations using the Kelvin_initialization module.
Added the new runtime parameters TIDAL_BAY_PERIOD and TIDAL_BAY_SSH_ANOM to specify the previously hard-coded dimensional parameters in the tidal_bay_initialization module. This change includes the addition of 2 new elements in the tidal_bay_OBC_CS type. By default all answers are bitwise identical, but there are new entries in the MOM_parameter_doc.all files for configurations using the tidal_bay_initialization module.
Hallberg-NOAA
force-pushed
the
explicit_OBC_user_params
branch
from
1eccf9a
to
7c12ead
Compare
|
I had put in the reciprocal of the right scaling factor in the get_param call for DUMBBELL_T_SURF with the previous version of this PR. It has now been corrected. @kshedstrom, if you would be willing to try out this revised version, I would appreciate it. |
|
Better now! I approve this PR. |
marshallward
approved these changes
Dec 29, 2022
|
Gaea regression: #290 ✔️ |
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 6 new runtime parameters to replace hard-coded dimensional
parameters in 3 user modules (dumbbell_initialization, Kelvin_initialization and
tidal_bay_initialization) that were added to provide tests of the OBC code. The
new runtime parameters that were added are DUMBBELL_T_LIGHT, KELVIN_WAVE_PERIOD,
KELVIN_WAVE_SSH_AMP, KELVIN_WAVE_INFLOW_AMP, TIDAL_BAY_PERIOD and
TIDAL_BAY_SSH_ANOM. By default all answers are bitwise identical, but there are
new entries in the MOM_parameter_doc.all files for configurations using the
three impacted modules.
The commits in this PR include: