(*)Fix bug in CVMix_shear_is_used if USE_PP81=True #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about adding the variable case parameter to the obsolete lists so users get a FATAL if trying to use it? |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #323 +/- ##
============================================
- Coverage 37.20% 37.20% -0.01%
============================================
Files 265 265
Lines 74431 74432 +1
Branches 13822 13822
============================================
- Hits 27690 27689 -1
- Misses 41650 41652 +2
Partials 5091 5091
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Because get_param is case-sensitive, CVMix_shear_is_used can incorrectly return false if USE_PP81 = True and USE_LMD94 = False. This would cause such cases to fail to reproduce across restarts or use uninitialize or incorrect arrays, but because the Pacanowski and Philader parameterization is very out-dated it appears not to be used in any active test case. Moreover, no one has reported any such issues yet. Therefore, rather than adding a flag to reproduce the old (unreproducing) results, this commit simply corrects this bug. The (case-sensitive) parameter "Use_PP81" was also formally obsoleted. All answers are bitwise identical in all known MOM6 configurations, but this could lead to answer changes in certain unlikely configurations.
Hallberg-NOAA
force-pushed
the
fix_CVMIX_shear_is_used_bug
branch
from
0691405
to
a9ee8d3
Compare
|
Also obsoleting the parameter "Use_PP81" is an excellent suggestion, and I have just updated the PR to include this. |
marshallward
approved these changes
Feb 15, 2023
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
get_param()is case-sensitive, CVMix_shear_is_used will incorrectly return false if USE_PP81 = True and USE_LMD94 = False. This would cause such cases to fail to reproduce across restarts or use uninitialized or incorrect arrays, but because the Pacanowski and Philader parameterization is very out-dated it appears not to be used in any active test case. Moreover, no one has reported any such issues yet. Therefore, rather than adding a flag to reproduce the old (unreproducing) results, this commit simply corrects this bug. All answers are bitwise identical in all known MOM6 configurations, but this could lead to answer changes in certain unlikely configurations.