Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflows: update to use actions/checkout@v3 #388

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

adcroft
Copy link
Member

@adcroft adcroft commented Jun 26, 2023

  • Updates actions/checkout from v2 to v3 . This simply uses the newer version of checkout and has no immediate impact, but does anticipate the inevitable need to roll forward.

Suggestion comes from NCAR#231 (comment) thanks to @jedwards4b) . I had imagined this commit was going to be cherry-picked some time ago but it seems it was not.

- Update actions/checkout from v2 to v3 (suggested at
  NCAR#231 (comment) thanks
  to @jedwards4b)
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #388 (ac6de0a) into dev/gfdl (201e705) will increase coverage by 1.19%.
The diff coverage is n/a.

❗ Current head ac6de0a differs from pull request most recent head d211735. Consider uploading reports for the commit d211735 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #388      +/-   ##
============================================
+ Coverage     37.03%   38.22%   +1.19%     
============================================
  Files           266      269       +3     
  Lines         75301    76359    +1058     
  Branches      14010    14025      +15     
============================================
+ Hits          27890    29191    +1301     
+ Misses        42121    41929     -192     
+ Partials       5290     5239      -51     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaea will not exercise these changes, so we can skip the regression test.

@marshallward marshallward merged commit cc1784c into NOAA-GFDL:dev/gfdl Jun 27, 2023
theresa-morrison pushed a commit to theresa-morrison/MOM6 that referenced this pull request Jul 26, 2023
  Removed the coord_slight module and all calls to it, and obsoleted all
run-time parameters that are exclusively related to it.  This code was an
attempt from 2015 to define an appropriate hybrid vertical coordinate for global
climate modeling, but it never worked very well (usually falling apart in the
second year), and it has not been used in any publication or active model for
many years.  The test case that exercised this coordinate in the MOM6-examples
test suite is also being removed via MOM6-examples PR NOAA-GFDL#388.  The coord_SLight
code is being eliminated altogether now to simplify the MOM6 code base and
reduce the volume of untested and unused code.  All answers in all known MOM6
configurations in active use are bitwise identical, although there is a remote
chance that someone somewhere might be using the SLIGHT coordinate.
@adcroft adcroft deleted the github-checkout-v3 branch July 28, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants