Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice-shelf solo driver and MISMIP+ updates #471

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

alex-huth
Copy link

-Several edits to the ice shelf solo driver so that it works with the rest of the current MOM6
-Added capability to initialize a surface mass balance (SMB) that is held contstant over time when running from the ice-shelf solo driver (see new subroutine initialize_ice_SMB). This is required for MISMIP+. A constant SMB can also be used from the MOM driver for coupled ice-shelf/ocean experiments (e.g. MISOMIP).
-The new, constant SMB is passed into solo_step_ice_shelf, where change_thickness_using_precip is called
-Added capability to save both non-time-stamped and time-stamped restart files when using the ice shelf solo driver. This is useful for debugging.
-slight reorganization to when ice shelf post_data calls are made

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #471 (4125523) into dev/gfdl (475590d) will decrease coverage by 0.05%.
The diff coverage is 12.69%.

❗ Current head 4125523 differs from pull request most recent head 7cd5e8d. Consider uploading reports for the commit 7cd5e8d to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #471      +/-   ##
============================================
- Coverage     37.83%   37.79%   -0.05%     
============================================
  Files           270      270              
  Lines         78346    78375      +29     
  Branches      14502    14533      +31     
============================================
- Hits          29643    29622      -21     
- Misses        43296    43318      +22     
- Partials       5407     5435      +28     
Files Coverage Δ
src/ice_shelf/MOM_ice_shelf_dynamics.F90 0.00% <0.00%> (ø)
config_src/drivers/solo_driver/MOM_driver.F90 50.62% <0.00%> (-0.43%) ⬇️
src/ice_shelf/MOM_ice_shelf.F90 0.00% <0.00%> (ø)
src/ice_shelf/MOM_ice_shelf_initialize.F90 0.00% <0.00%> (ø)
src/framework/MOM_diag_mediator.F90 57.50% <22.22%> (-1.32%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why we need a separate solo_ice_shelf_diag_mediator_end() routine in MOM_diag_mediator.F90 that is distict from diag_mediator_end(). They appear to me to take the same arguments and do the same thing, perhaps with a little error checking. Given that they are so similar, why not add the safety checks to diag_mediator_end()?

Also, the capability being added with the new runtime parameter SAVE_BOTH_RESTARTS could already have been obtained by setting RESTART_CONTROL=3. The new parameter may be more explicit, but it does add to the list of parameters without actually adding any new capabilities.

@alex-huth
Copy link
Author

I revised the PR as suggested by @Hallberg-NOAA . I added safety checks to diag_mediator_end() so that the separate solo_ice_shelf_diag_mediator_end() routine is no longer necessary. I also removed the SAVE_BOTH_RESTARTS option, which was useful during development, but is not needed anymore.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This set of code changes looks reasonable to me.

-Several edits to the ice shelf solo driver so that it works with the rest of the current MOM6
-Added capability to initialize a surface mass balance (SMB) that is held contstant over time when running from the ice-shelf solo driver (see new subroutine initialize_ice_SMB). This is required for MISMIP+. A constant SMB can also be used from the MOM driver for coupled ice-shelf/ocean experiments (e.g. MISOMIP).
-The new, constant SMB is passed into solo_step_ice_shelf, where change_thickness_using_precip is called
-Added capability to save both non-time-stamped and time-stamped restart files when using the ice shelf solo driver. This is useful for debugging.
-slight reorganization to when ice shelf post_data calls are made
…ice shelf solo-driver, which now calls it instead of (now removed) solo_ice_shelf_diag_mediator_end() routine. Removed the runtime parameter SAVE_BOTH_RESTARTS from the ice shelf solo-driver, which is no longer needed.
@marshallward marshallward merged commit ac66061 into NOAA-GFDL:dev/gfdl Oct 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants