Update and bugfix to movement of the ice-shelf front #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #475 +/- ##
=========================================
Coverage 37.54% 37.54%
=========================================
Files 270 270
Lines 79030 79030
Branches 14635 14635
=========================================
Hits 29670 29670
Misses 43894 43894
Partials 5466 5466
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
force-pushed
the
dev/gfdl
branch
from
8a66adc
to
9de6ce7
Compare
… a partially-filled cell, add the reference thickness contribution from a neighboring filled cell proportionate to its flux into the partially-filled cell. This is more accurate than simply taking the average thickness of all neighboring filled cells. Also fixed incorrect bounds.
alex-huth
force-pushed
the
front_advect_fix
branch
from
b7593e2
to
5691756
Compare
Hallberg-NOAA
approved these changes
Oct 27, 2023
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21119. |
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an ice-shelf cell transitioned from partially-full to full, it was assigned a "reference thickness" equal to the average thickness of surrounding filled cells. In this PR, this average is instead weighted by the flux from each filled cell into the partially-filled cell. This flux-weighted average is more accurate.
Also fixed the incorrect computational bounds used during advection of the ice-shelf front.
The PR has been tested by running the flow-band ice shelf test for 300 years, where the modeled ice-shelf evolution sufficiently matched the analytical solutions for ice-shelf thickness, velocity, and front advection.