Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing additional surface variables into the atmospheric model #28

Open
zhihong-tan opened this issue Oct 16, 2023 · 0 comments
Open

Passing additional surface variables into the atmospheric model #28

zhihong-tan opened this issue Oct 16, 2023 · 0 comments

Comments

@zhihong-tan
Copy link
Contributor

A new boundary layer scheme (NCEP TKE-based eddy-diffusivity mass-flux scheme) is being implemented in the prototype-AM5 model, and it requires five additional surface variables (shflx, lhflx, wind, thv_atm, and thv_surf) as inputs. Thus, I would like to add a few lines in the atmos_driver (coupled/atmos_model.F90) to pass these variables into the physics driver. (A "ifdef" statement is added to maintain backward compatibility with AM4's physics driver).

This issue is associated with the issue I just opened for the FMScoupler repository.
@zhihong-tan zhihong-tan mentioned this issue Oct 16, 2023
Merged
5 tasks
laurenchilutti pushed a commit that referenced this issue Nov 27, 2023
@zhihong-tan
Passing additional surface variables into the atmospheric model #28 (#29
62279bb 
)

* ADDED SURFACE VARIABLES REQUIRED BY NCEP TKE-EDMF

The shflx, lhflx, wind, thv_atm, thv_surf variables are passed
from the surface coupler to the atmospheric model as required by
the NCEP TKE-EDMF scheme.

* CONDITIONAL COMPILATION FLAG FOR AM4 COMPATIBILITY

For compatibility with AM4, a ifdef-statement with a conditional
compilation flag "do_am5phys" is added in the call to
physics_driver_down to prevent the additional surface variables
from being passed into the old AM4 physics package. This flag
should be defined if AM5 is compiled with NCEP TKE-based EDMF.

* REMOVED NAME TAGS FROM THE COMMENTS

* REMOVING THE CONDITIONAL COMPILATION FLAG

The added variables are now passed as optional arguments into
physics_driver_down. This requires consistent changes in the
atmos_phys package.

* ADDED IF-STATEMENTS FOR CHECKSUM

Two if-associated statements are added before the checksums
of bnd_type%shflx and bnd_type%lhflx to pass the null model
build.

* Changed the name for EDMF in the comments

The full name for the NCEP TKE-based EDMF replaces the informal
short name (HanEDMF) in the comments only. No other code changes.

* Modified the comments for new fields

The term 'surface' in the comments for the added fields is
clarified as the lowest atmos level as Sergey suggested.

---------

Co-authored-by: Zhihong Tan <Zhihong.Tan@gaea52.ncrc.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhihong-tan